Skip to content

Commit 95d56df

Browse files
CFSworksffainelli
authored andcommitted
arm64: dts: broadcom: bcmbca: bcm4908: Protect cpu-release-addr
The `cpu-release-addr` property is relevant only when the "spin-table" enable method is used. It is the physical address where the bootloader expects Linux to write the secondary CPU entry point's physical address. On this platform, only the CFE bootloader uses this method: U-Boot uses PSCI instead. CFE actually walks the FDT to learn this address, so we're free to put it wherever we want. We only need to make sure that it goes in a reserved-memory block so that writing to it during early boot does not risk conflicting with an unrelated memory allocation: this was not done. Since the previous patch reserved the first page of memory for CFE's secondary-CPU init stub, which is actually much smaller than a page, just put this address at the end of that page and it shall be so protected. Signed-off-by: Sam Edwards <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Florian Fainelli <[email protected]>
1 parent cef3139 commit 95d56df

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
compatible = "brcm,brahma-b53";
3131
reg = <0x0>;
3232
enable-method = "spin-table";
33-
cpu-release-addr = <0x0 0xfff8>;
33+
cpu-release-addr = <0x0 0xff8>;
3434
next-level-cache = <&l2>;
3535
};
3636

@@ -39,7 +39,7 @@
3939
compatible = "brcm,brahma-b53";
4040
reg = <0x1>;
4141
enable-method = "spin-table";
42-
cpu-release-addr = <0x0 0xfff8>;
42+
cpu-release-addr = <0x0 0xff8>;
4343
next-level-cache = <&l2>;
4444
};
4545

@@ -48,7 +48,7 @@
4848
compatible = "brcm,brahma-b53";
4949
reg = <0x2>;
5050
enable-method = "spin-table";
51-
cpu-release-addr = <0x0 0xfff8>;
51+
cpu-release-addr = <0x0 0xff8>;
5252
next-level-cache = <&l2>;
5353
};
5454

@@ -57,7 +57,7 @@
5757
compatible = "brcm,brahma-b53";
5858
reg = <0x3>;
5959
enable-method = "spin-table";
60-
cpu-release-addr = <0x0 0xfff8>;
60+
cpu-release-addr = <0x0 0xff8>;
6161
next-level-cache = <&l2>;
6262
};
6363

0 commit comments

Comments
 (0)