Skip to content

Commit 963795f

Browse files
committed
Merge tag 'x86-fpu-2024-05-13' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull x86 fpu updates from Ingo Molnar: - Fix asm() constraints & modifiers in restore_fpregs_from_fpstate() - Update comments - Robustify the free_vm86() definition * tag 'x86-fpu-2024-05-13' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86/fpu: Update fpu_swap_kvm_fpu() uses in comments as well x86/vm86: Make sure the free_vm86(task) definition uses its parameter even in the !CONFIG_VM86 case x86/fpu: Fix AMD X86_BUG_FXSAVE_LEAK fixup
2 parents 31a568b + af813ac commit 963795f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

arch/x86/include/asm/vm86.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ static inline int handle_vm86_trap(struct kernel_vm86_regs *a, long b, int c)
8484

8585
static inline void save_v86_state(struct kernel_vm86_regs *a, int b) { }
8686

87-
#define free_vm86(t) do { } while(0)
87+
#define free_vm86(task) do { (void)(task); } while(0)
8888

8989
#endif /* CONFIG_VM86 */
9090

arch/x86/kernel/fpu/core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ void restore_fpregs_from_fpstate(struct fpstate *fpstate, u64 mask)
145145
asm volatile(
146146
"fnclex\n\t"
147147
"emms\n\t"
148-
"fildl %P[addr]" /* set F?P to defined value */
149-
: : [addr] "m" (fpstate));
148+
"fildl %[addr]" /* set F?P to defined value */
149+
: : [addr] "m" (*fpstate));
150150
}
151151

152152
if (use_xsave()) {

arch/x86/kernel/fpu/xstate.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1434,8 +1434,8 @@ static bool xstate_op_valid(struct fpstate *fpstate, u64 mask, bool rstor)
14341434
return rstor;
14351435

14361436
/*
1437-
* XSAVE(S): clone(), fpu_swap_kvm_fpu()
1438-
* XRSTORS(S): fpu_swap_kvm_fpu()
1437+
* XSAVE(S): clone(), fpu_swap_kvm_fpstate()
1438+
* XRSTORS(S): fpu_swap_kvm_fpstate()
14391439
*/
14401440

14411441
/*

0 commit comments

Comments
 (0)