Skip to content

Commit 965e49c

Browse files
ujfalusibroonie
authored andcommitted
ASoC: SOF: ipc4-pcm: Use consistent name for snd_sof_pcm_stream pointer
Throughout the file the pointer for snd_sof_pcm_stream is named either 'stream' or (wrongly) 'spcm' which confuses the reader. Use 'sps' for the pointer name as it is the most common name used in SOF codebase. Signed-off-by: Peter Ujfalusi <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> Reviewed-by: Ranjani Sridharan <[email protected]> Link: https://msgid.link/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent fec50db commit 965e49c

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

sound/soc/sof/ipc4-pcm.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm
764764
return 0;
765765
}
766766

767-
static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pcm_stream *spcm)
767+
static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pcm_stream *sps)
768768
{
769769
struct sof_ipc4_copier *host_copier = NULL;
770770
struct sof_ipc4_copier *dai_copier = NULL;
@@ -775,7 +775,7 @@ static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pc
775775
int i;
776776

777777
/* find host & dai to locate info in memory window */
778-
for_each_dapm_widgets(spcm->list, i, widget) {
778+
for_each_dapm_widgets(sps->list, i, widget) {
779779
struct snd_sof_widget *swidget = widget->dobj.private;
780780

781781
if (!swidget)
@@ -795,7 +795,7 @@ static void sof_ipc4_build_time_info(struct snd_sof_dev *sdev, struct snd_sof_pc
795795
return;
796796
}
797797

798-
info = spcm->private;
798+
info = sps->private;
799799
info->host_copier = host_copier;
800800
info->dai_copier = dai_copier;
801801
info->llp_offset = offsetof(struct sof_ipc4_fw_registers, llp_gpdma_reading_slots) +
@@ -864,7 +864,7 @@ static int sof_ipc4_pcm_hw_params(struct snd_soc_component *component,
864864

865865
static int sof_ipc4_get_stream_start_offset(struct snd_sof_dev *sdev,
866866
struct snd_pcm_substream *substream,
867-
struct snd_sof_pcm_stream *stream,
867+
struct snd_sof_pcm_stream *sps,
868868
struct sof_ipc4_timestamp_info *time_info)
869869
{
870870
struct sof_ipc4_copier *host_copier = time_info->host_copier;
@@ -918,7 +918,7 @@ static int sof_ipc4_pcm_pointer(struct snd_soc_component *component,
918918
struct sof_ipc4_timestamp_info *time_info;
919919
struct sof_ipc4_llp_reading_slot llp;
920920
snd_pcm_uframes_t head_cnt, tail_cnt;
921-
struct snd_sof_pcm_stream *stream;
921+
struct snd_sof_pcm_stream *sps;
922922
u64 dai_cnt, host_cnt, host_ptr;
923923
struct snd_sof_pcm *spcm;
924924
int ret;
@@ -927,8 +927,8 @@ static int sof_ipc4_pcm_pointer(struct snd_soc_component *component,
927927
if (!spcm)
928928
return -EOPNOTSUPP;
929929

930-
stream = &spcm->stream[substream->stream];
931-
time_info = stream->private;
930+
sps = &spcm->stream[substream->stream];
931+
time_info = sps->private;
932932
if (!time_info)
933933
return -EOPNOTSUPP;
934934

@@ -938,7 +938,7 @@ static int sof_ipc4_pcm_pointer(struct snd_soc_component *component,
938938
* the statistics is complete. And it will not change after the first initiailization.
939939
*/
940940
if (time_info->stream_start_offset == SOF_IPC4_INVALID_STREAM_POSITION) {
941-
ret = sof_ipc4_get_stream_start_offset(sdev, substream, stream, time_info);
941+
ret = sof_ipc4_get_stream_start_offset(sdev, substream, sps, time_info);
942942
if (ret < 0)
943943
return -EOPNOTSUPP;
944944
}
@@ -1030,15 +1030,15 @@ static snd_pcm_sframes_t sof_ipc4_pcm_delay(struct snd_soc_component *component,
10301030
{
10311031
struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
10321032
struct sof_ipc4_timestamp_info *time_info;
1033-
struct snd_sof_pcm_stream *stream;
1033+
struct snd_sof_pcm_stream *sps;
10341034
struct snd_sof_pcm *spcm;
10351035

10361036
spcm = snd_sof_find_spcm_dai(component, rtd);
10371037
if (!spcm)
10381038
return 0;
10391039

1040-
stream = &spcm->stream[substream->stream];
1041-
time_info = stream->private;
1040+
sps = &spcm->stream[substream->stream];
1041+
time_info = sps->private;
10421042
/*
10431043
* Report the stored delay value calculated in the pointer callback.
10441044
* In the unlikely event that the calculation was skipped/aborted, the

0 commit comments

Comments
 (0)