Skip to content

Commit 966334d

Browse files
dbasehoredtor
authored andcommitted
Input: elan_i2c - only increment wakeup count on touch
This moves the wakeup increment for elan devices to the touch report. This prevents the drivers from incorrectly reporting a wakeup when the resume callback resets then device, which causes an interrupt to occur. Signed-off-by: Derek Basehore <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent dcb00fc commit 966334d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

drivers/input/mouse/elan_i2c_core.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -951,6 +951,8 @@ static void elan_report_absolute(struct elan_tp_data *data, u8 *packet)
951951
u8 hover_info = packet[ETP_HOVER_INFO_OFFSET];
952952
bool contact_valid, hover_event;
953953

954+
pm_wakeup_event(&data->client->dev, 0);
955+
954956
hover_event = hover_info & 0x40;
955957
for (i = 0; i < ETP_MAX_FINGERS; i++) {
956958
contact_valid = tp_info & (1U << (3 + i));
@@ -974,6 +976,8 @@ static void elan_report_trackpoint(struct elan_tp_data *data, u8 *report)
974976
u8 *packet = &report[ETP_REPORT_ID_OFFSET + 1];
975977
int x, y;
976978

979+
pm_wakeup_event(&data->client->dev, 0);
980+
977981
if (!data->tp_input) {
978982
dev_warn_once(&data->client->dev,
979983
"received a trackpoint report while no trackpoint device has been created. Please report upstream.\n");
@@ -998,7 +1002,6 @@ static void elan_report_trackpoint(struct elan_tp_data *data, u8 *report)
9981002
static irqreturn_t elan_isr(int irq, void *dev_id)
9991003
{
10001004
struct elan_tp_data *data = dev_id;
1001-
struct device *dev = &data->client->dev;
10021005
int error;
10031006
u8 report[ETP_MAX_REPORT_LEN];
10041007

@@ -1016,8 +1019,6 @@ static irqreturn_t elan_isr(int irq, void *dev_id)
10161019
if (error)
10171020
goto out;
10181021

1019-
pm_wakeup_event(dev, 0);
1020-
10211022
switch (report[ETP_REPORT_ID_OFFSET]) {
10221023
case ETP_REPORT_ID:
10231024
elan_report_absolute(data, report);
@@ -1026,7 +1027,7 @@ static irqreturn_t elan_isr(int irq, void *dev_id)
10261027
elan_report_trackpoint(data, report);
10271028
break;
10281029
default:
1029-
dev_err(dev, "invalid report id data (%x)\n",
1030+
dev_err(&data->client->dev, "invalid report id data (%x)\n",
10301031
report[ETP_REPORT_ID_OFFSET]);
10311032
}
10321033

0 commit comments

Comments
 (0)