Skip to content

Commit 966b753

Browse files
ssuthiku-amdjoergroedel
authored andcommitted
iommu/amd: Only support x2APIC with IVHD type 11h/40h
Current implementation for IOMMU x2APIC support makes use of the MMIO access to MSI capability block registers, which requires checking EFR[MsiCapMmioSup]. However, only IVHD type 11h/40h contain the information, and not in the IVHD type 10h IOMMU feature reporting field. Since the BIOS in newer systems, which supports x2APIC, would normally contain IVHD type 11h/40h, remove the IOMMU_FEAT_XTSUP_SHIFT check for IVHD type 10h, and only support x2APIC with IVHD type 11h/40h. Fixes: 6692981 ('iommu/amd: Add support for X2APIC IOMMU interrupts') Signed-off-by: Suravee Suthikulpanit <[email protected]> Signed-off-by: Joerg Roedel <[email protected]>
1 parent 8130714 commit 966b753

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

drivers/iommu/amd_iommu_init.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1523,8 +1523,6 @@ static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h)
15231523
iommu->mmio_phys_end = MMIO_CNTR_CONF_OFFSET;
15241524
if (((h->efr_attr & (0x1 << IOMMU_FEAT_GASUP_SHIFT)) == 0))
15251525
amd_iommu_guest_ir = AMD_IOMMU_GUEST_IR_LEGACY;
1526-
if (((h->efr_attr & (0x1 << IOMMU_FEAT_XTSUP_SHIFT)) == 0))
1527-
amd_iommu_xt_mode = IRQ_REMAP_XAPIC_MODE;
15281526
break;
15291527
case 0x11:
15301528
case 0x40:

drivers/iommu/amd_iommu_types.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,6 @@
377377
#define IOMMU_CAP_EFR 27
378378

379379
/* IOMMU Feature Reporting Field (for IVHD type 10h */
380-
#define IOMMU_FEAT_XTSUP_SHIFT 0
381380
#define IOMMU_FEAT_GASUP_SHIFT 6
382381

383382
/* IOMMU Extended Feature Register (EFR) */

0 commit comments

Comments
 (0)