Skip to content

Commit 96e39e9

Browse files
shawnguo2JassiBrar
authored andcommitted
mailbox: qcom: Use PLATFORM_DEVID_AUTO to register platform device
In adding APCS clock support for MSM8939, the second clock registration fails due to duplicate device name like below. [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' ... [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk This is because MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect). Although only APCS of Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock control bits. That said, 3 'qcom-apcs-msm8916-clk' devices need to be registered to instantiate all 3 clocks. Use PLATFORM_DEVID_AUTO rather than PLATFORM_DEVID_NONE for platform_device_register_data() call to fix the issue above. Signed-off-by: Shawn Guo <[email protected]> Reviewed-by: Bjorn Andersson <[email protected]> Signed-off-by: Jassi Brar <[email protected]>
1 parent 2ef6123 commit 96e39e9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mailbox/qcom-apcs-ipc-mailbox.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
136136
if (apcs_data->clk_name) {
137137
apcs->clk = platform_device_register_data(&pdev->dev,
138138
apcs_data->clk_name,
139-
PLATFORM_DEVID_NONE,
139+
PLATFORM_DEVID_AUTO,
140140
NULL, 0);
141141
if (IS_ERR(apcs->clk))
142142
dev_err(&pdev->dev, "failed to register APCS clk\n");

0 commit comments

Comments
 (0)