powerpc/ps3: Remove an unneeded NULL check

Dan Carpenter · mpe · commit 96efbab92ccc · 2020-04-03T00:09:59.000+11:00
Static checkers don't like the inconsistent NULL checking on "ops". This function is only called once and "ops" isn't NULL so the check can be removed. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Geoff Levand <geoff@infradead.org> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/ddc3513dc54d15456692c80df49287fe3babe40a.1585340156.git.geoff@infradead.org
diff --git a/drivers/ps3/sys-manager-core.c b/drivers/ps3/sys-manager-core.c
@@ -31,7 +31,7 @@ void ps3_sys_manager_register_ops(const struct ps3_sys_manager_ops *ops)
 {
 	BUG_ON(!ops);
 	BUG_ON(!ops->dev);
-	ps3_sys_manager_ops = ops ? *ops : ps3_sys_manager_ops;
+	ps3_sys_manager_ops = *ops;
 }
 EXPORT_SYMBOL_GPL(ps3_sys_manager_register_ops);
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ void ps3_sys_manager_register_ops(const struct ps3_sys_manager_ops *ops)`
`31`	`31`	`{`
`32`	`32`	`BUG_ON(!ops);`
`33`	`33`	`BUG_ON(!ops->dev);`
`34`		`- ps3_sys_manager_ops = ops ? *ops : ps3_sys_manager_ops;`
	`34`	`+ ps3_sys_manager_ops = *ops;`
`35`	`35`	`}`
`36`	`36`	`EXPORT_SYMBOL_GPL(ps3_sys_manager_register_ops);`
`37`	`37`