Skip to content

Commit 96fd2e8

Browse files
ZhengjunXingPeter Zijlstra
authored andcommitted
perf/x86/intel/uncore: Fix CAS_COUNT_WRITE issue for ICX
The user recently report a perf issue in the ICX platform, when test by perf event “uncore_imc_x/cas_count_write”,the write bandwidth is always very small (only 0.38MB/s), it is caused by the wrong "umask" for the "cas_count_write" event. When double-checking, find "cas_count_read" also is wrong. The public document for ICX uncore: 3rd Gen Intel® Xeon® Processor Scalable Family, Codename Ice Lake,Uncore Performance Monitoring Reference Manual, Revision 1.00, May 2021 On 2.4.7, it defines Unit Masks for CAS_COUNT: RD b00001111 WR b00110000 So corrected both "cas_count_read" and "cas_count_write" for ICX. Old settings: hswep_uncore_imc_events INTEL_UNCORE_EVENT_DESC(cas_count_read, "event=0x04,umask=0x03") INTEL_UNCORE_EVENT_DESC(cas_count_write, "event=0x04,umask=0x0c") New settings: snr_uncore_imc_events INTEL_UNCORE_EVENT_DESC(cas_count_read, "event=0x04,umask=0x0f") INTEL_UNCORE_EVENT_DESC(cas_count_write, "event=0x04,umask=0x30") Fixes: 2b3b76b ("perf/x86/intel/uncore: Add Ice Lake server uncore support") Signed-off-by: Zhengjun Xing <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Adrian Hunter <[email protected]> Reviewed-by: Kan Liang <[email protected]> Cc: [email protected] Link: https://lkml.kernel.org/r/[email protected]
1 parent 7fa981c commit 96fd2e8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/events/intel/uncore_snbep.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5482,7 +5482,7 @@ static struct intel_uncore_type icx_uncore_imc = {
54825482
.fixed_ctr_bits = 48,
54835483
.fixed_ctr = SNR_IMC_MMIO_PMON_FIXED_CTR,
54845484
.fixed_ctl = SNR_IMC_MMIO_PMON_FIXED_CTL,
5485-
.event_descs = hswep_uncore_imc_events,
5485+
.event_descs = snr_uncore_imc_events,
54865486
.perf_ctr = SNR_IMC_MMIO_PMON_CTR0,
54875487
.event_ctl = SNR_IMC_MMIO_PMON_CTL0,
54885488
.event_mask = SNBEP_PMON_RAW_EVENT_MASK,

0 commit comments

Comments
 (0)