Skip to content

Commit 97341ef

Browse files
jwrdegoedegregkh
authored andcommitted
usb: typec: pi3usb30532: Set switch_ / mux_desc name field to NULL
Since commit ef441dd ("usb: typec: mux: Allow the muxes to be named") the typec_switch_desc and typec_mux_desc structs contain a name field. The pi3usb30532 driver allocates these structs on the stack and so far did not explicitly zero the mem used for the structs. This causes the new name fields to point to a random memory address, which in my test case happens to be a valid address leading to "interesting" mux / switch names: [root@localhost ~]# ls -l /sys/class/typec_mux/ total 0 lrwxrwxrwx. 1 root root 0 Apr 14 12:55 ''$'\r''-switch' -> ... lrwxrwxrwx. 1 root root 0 Apr 14 12:55 ''$'\320\302\006''2'$'... Explicitly initialize the structs to zero when declaring them on the stack so that any unused fields get set to 0, fixing this. Fixes: ef441dd ("usb: typec: mux: Allow the muxes to be named") Signed-off-by: Hans de Goede <[email protected]> Acked-by: Heikki Krogerus <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 7dbdb53 commit 97341ef

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/usb/typec/mux/pi3usb30532.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ pi3usb30532_mux_set(struct typec_mux *mux, struct typec_mux_state *state)
114114
static int pi3usb30532_probe(struct i2c_client *client)
115115
{
116116
struct device *dev = &client->dev;
117-
struct typec_switch_desc sw_desc;
118-
struct typec_mux_desc mux_desc;
117+
struct typec_switch_desc sw_desc = { };
118+
struct typec_mux_desc mux_desc = { };
119119
struct pi3usb30532 *pi;
120120
int ret;
121121

0 commit comments

Comments
 (0)