Skip to content

Commit 9764929

Browse files
rmurphy-armwilldeacon
authored andcommitted
iommu/arm-smmu: Update impl quirks comment
The comment about implementation and integration quirks being mutually-exclusive is out of date, and in fact the code is already structured for the case it anticipates, so document that properly. Signed-off-by: Robin Murphy <[email protected]> Link: https://lore.kernel.org/r/1e742177e084621f3454fbaf768325a6c215656a.1592994291.git.robin.murphy@arm.com Signed-off-by: Will Deacon <[email protected]>
1 parent ecd7274 commit 9764929

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/iommu/arm-smmu-impl.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,9 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu)
153153
const struct device_node *np = smmu->dev->of_node;
154154

155155
/*
156-
* We will inevitably have to combine model-specific implementation
157-
* quirks with platform-specific integration quirks, but everything
158-
* we currently support happens to work out as straightforward
159-
* mutually-exclusive assignments.
156+
* Set the impl for model-specific implementation quirks first,
157+
* such that platform integration quirks can pick it up and
158+
* inherit from it if necessary.
160159
*/
161160
switch (smmu->model) {
162161
case ARM_MMU500:
@@ -168,6 +167,7 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu)
168167
break;
169168
}
170169

170+
/* This is implicitly MMU-400 */
171171
if (of_property_read_bool(np, "calxeda,smmu-secure-config-access"))
172172
smmu->impl = &calxeda_impl;
173173

0 commit comments

Comments
 (0)