Skip to content

Commit 9778448

Browse files
SinkFinderaxboe
authored andcommitted
lightnvm: fix memory leak when submit fails
The allocated page is not released if error occurs in nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid possible memory leak issue. Fixes: aff3fb1 ("lightnvm: move bad block and chunk state logic to core") Signed-off-by: Pan Bian <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 1df35bf commit 9778448

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/lightnvm/core.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -844,11 +844,10 @@ static int nvm_bb_chunk_sense(struct nvm_dev *dev, struct ppa_addr ppa)
844844
rqd.ppa_addr = generic_to_dev_addr(dev, ppa);
845845

846846
ret = nvm_submit_io_sync_raw(dev, &rqd);
847+
__free_page(page);
847848
if (ret)
848849
return ret;
849850

850-
__free_page(page);
851-
852851
return rqd.error;
853852
}
854853

0 commit comments

Comments
 (0)