Skip to content

Commit 977dfef

Browse files
committed
ALSA: hda: Match both PCI ID and SSID for driver blacklist
The commit 3c6fd1f ("ALSA: hda: Add driver blacklist") added a new blacklist for the devices that are known to have empty codecs, and one of the entries was ASUS ROG Zenith II (PCI SSID 1043:874f). However, it turned out that the very same PCI SSID is used for the previous model that does have the valid HD-audio codecs and the change broke the sound on it. Since the empty codec problem appear on the certain AMD platform (PCI ID 1022:1487), this patch changes the blacklist matching to both PCI ID and SSID using pci_match_id(). Also, the entry that was removed by the previous fix for ASUS ROG Zenigh II is re-added. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 8d6762a commit 977dfef

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

sound/pci/hda/hda_intel.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2078,9 +2078,10 @@ static void pcm_mmap_prepare(struct snd_pcm_substream *substream,
20782078
* some HD-audio PCI entries are exposed without any codecs, and such devices
20792079
* should be ignored from the beginning.
20802080
*/
2081-
static const struct snd_pci_quirk driver_blacklist[] = {
2082-
SND_PCI_QUIRK(0x1462, 0xcb59, "MSI TRX40 Creator", 0),
2083-
SND_PCI_QUIRK(0x1462, 0xcb60, "MSI TRX40", 0),
2081+
static const struct pci_device_id driver_blacklist[] = {
2082+
{ PCI_DEVICE_SUB(0x1022, 0x1487, 0x1043, 0x874f) }, /* ASUS ROG Zenith II / Strix */
2083+
{ PCI_DEVICE_SUB(0x1022, 0x1487, 0x1462, 0xcb59) }, /* MSI TRX40 Creator */
2084+
{ PCI_DEVICE_SUB(0x1022, 0x1487, 0x1462, 0xcb60) }, /* MSI TRX40 */
20842085
{}
20852086
};
20862087

@@ -2100,7 +2101,7 @@ static int azx_probe(struct pci_dev *pci,
21002101
bool schedule_probe;
21012102
int err;
21022103

2103-
if (snd_pci_quirk_lookup(pci, driver_blacklist)) {
2104+
if (pci_match_id(driver_blacklist, pci)) {
21042105
dev_info(&pci->dev, "Skipping the blacklisted device\n");
21052106
return -ENODEV;
21062107
}

0 commit comments

Comments
 (0)