Skip to content

Commit 979e52c

Browse files
committed
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
Pull crypto fix from Herbert Xu: "This fixes a correctness bug in the ARM64 version of ChaCha for lib/crypto used by WireGuard" * 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6: crypto: arm64/chacha - correctly walk through blocks
2 parents 16fbf79 + c8cfcb7 commit 979e52c

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

arch/arm64/crypto/chacha-neon-glue.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ static void chacha_doneon(u32 *state, u8 *dst, const u8 *src,
5555
break;
5656
}
5757
chacha_4block_xor_neon(state, dst, src, nrounds, l);
58-
bytes -= CHACHA_BLOCK_SIZE * 5;
59-
src += CHACHA_BLOCK_SIZE * 5;
60-
dst += CHACHA_BLOCK_SIZE * 5;
61-
state[12] += 5;
58+
bytes -= l;
59+
src += l;
60+
dst += l;
61+
state[12] += DIV_ROUND_UP(l, CHACHA_BLOCK_SIZE);
6262
}
6363
}
6464

lib/crypto/chacha20poly1305-selftest.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9028,10 +9028,15 @@ bool __init chacha20poly1305_selftest(void)
90289028
&& total_len <= 1 << 10; ++total_len) {
90299029
for (i = 0; i <= total_len; ++i) {
90309030
for (j = i; j <= total_len; ++j) {
9031+
k = 0;
90319032
sg_init_table(sg_src, 3);
9032-
sg_set_buf(&sg_src[0], input, i);
9033-
sg_set_buf(&sg_src[1], input + i, j - i);
9034-
sg_set_buf(&sg_src[2], input + j, total_len - j);
9033+
if (i)
9034+
sg_set_buf(&sg_src[k++], input, i);
9035+
if (j - i)
9036+
sg_set_buf(&sg_src[k++], input + i, j - i);
9037+
if (total_len - j)
9038+
sg_set_buf(&sg_src[k++], input + j, total_len - j);
9039+
sg_init_marker(sg_src, k);
90359040
memset(computed_output, 0, total_len);
90369041
memset(input, 0, total_len);
90379042

0 commit comments

Comments
 (0)