Skip to content

Commit 9875b54

Browse files
gabaydjmberg-intel
authored andcommitted
wifi: iwlwifi: Ensure prph_mac dump includes all addresses
In prph_mac_iter, ensure that all required addresses are dumped even if a read fails. Currently, if a read fails, the region dump is stopped, preventing the creation of prph_mac.lst. By dumping all addresses even if a read fails, we can accurately determine which addresses were successfully read and which were not. Signed-off-by: Daniel Gabay <[email protected]> Reviewed-by: Eilon Rinat <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://msgid.link/20240506095953.31fa9ce91a1c.Ia0c86f70c7a6874c15ffc6f8235aa88530208546@changeid Signed-off-by: Johannes Berg <[email protected]>
1 parent b31b77b commit 9875b54

File tree

1 file changed

+2
-7
lines changed
  • drivers/net/wireless/intel/iwlwifi/fw

1 file changed

+2
-7
lines changed

drivers/net/wireless/intel/iwlwifi/fw/dbg.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1026,17 +1026,12 @@ static int iwl_dump_ini_prph_mac_iter_common(struct iwl_fw_runtime *fwrt,
10261026
{
10271027
struct iwl_fw_ini_error_dump_range *range = range_ptr;
10281028
__le32 *val = range->data;
1029-
u32 prph_val;
10301029
int i;
10311030

10321031
range->internal_base_addr = cpu_to_le32(addr);
10331032
range->range_data_size = size;
1034-
for (i = 0; i < le32_to_cpu(size); i += 4) {
1035-
prph_val = iwl_read_prph(fwrt->trans, addr + i);
1036-
if (iwl_trans_is_hw_error_value(prph_val))
1037-
return -EBUSY;
1038-
*val++ = cpu_to_le32(prph_val);
1039-
}
1033+
for (i = 0; i < le32_to_cpu(size); i += 4)
1034+
*val++ = cpu_to_le32(iwl_read_prph(fwrt->trans, addr + i));
10401035

10411036
return sizeof(*range) + le32_to_cpu(range->range_data_size);
10421037
}

0 commit comments

Comments
 (0)