Skip to content

Commit 9882913

Browse files
Taniya Dasbebarino
authored andcommitted
clk: qcom: gcc-sc7180: Mark the camera abh clock always ON
The camera clock controller requires the AHB clock, the driver when moved to use the pm_runtime_get() API, the camera ahb clock failed turn on before access, thus mark it as always ON. Reported-by: Stephen Boyd <[email protected]> Fixes: 8d40259 ("clk: qcom: camcc-sc7180: Use runtime PM ops instead of clk ones") Signed-off-by: Taniya Das <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]>
1 parent 5c8fe58 commit 9882913

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

drivers/clk/qcom/gcc-sc7180.c

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -891,21 +891,6 @@ static struct clk_branch gcc_boot_rom_ahb_clk = {
891891
},
892892
};
893893

894-
static struct clk_branch gcc_camera_ahb_clk = {
895-
.halt_reg = 0xb008,
896-
.halt_check = BRANCH_HALT,
897-
.hwcg_reg = 0xb008,
898-
.hwcg_bit = 1,
899-
.clkr = {
900-
.enable_reg = 0xb008,
901-
.enable_mask = BIT(0),
902-
.hw.init = &(struct clk_init_data){
903-
.name = "gcc_camera_ahb_clk",
904-
.ops = &clk_branch2_ops,
905-
},
906-
},
907-
};
908-
909894
static struct clk_branch gcc_camera_hf_axi_clk = {
910895
.halt_reg = 0xb020,
911896
.halt_check = BRANCH_HALT,
@@ -2317,7 +2302,6 @@ static struct clk_regmap *gcc_sc7180_clocks[] = {
23172302
[GCC_AGGRE_UFS_PHY_AXI_CLK] = &gcc_aggre_ufs_phy_axi_clk.clkr,
23182303
[GCC_AGGRE_USB3_PRIM_AXI_CLK] = &gcc_aggre_usb3_prim_axi_clk.clkr,
23192304
[GCC_BOOT_ROM_AHB_CLK] = &gcc_boot_rom_ahb_clk.clkr,
2320-
[GCC_CAMERA_AHB_CLK] = &gcc_camera_ahb_clk.clkr,
23212305
[GCC_CAMERA_HF_AXI_CLK] = &gcc_camera_hf_axi_clk.clkr,
23222306
[GCC_CAMERA_THROTTLE_HF_AXI_CLK] = &gcc_camera_throttle_hf_axi_clk.clkr,
23232307
[GCC_CAMERA_XO_CLK] = &gcc_camera_xo_clk.clkr,
@@ -2519,11 +2503,12 @@ static int gcc_sc7180_probe(struct platform_device *pdev)
25192503

25202504
/*
25212505
* Keep the clocks always-ON
2522-
* GCC_CPUSS_GNOC_CLK, GCC_VIDEO_AHB_CLK, GCC_DISP_AHB_CLK
2523-
* GCC_GPU_CFG_AHB_CLK
2506+
* GCC_CPUSS_GNOC_CLK, GCC_VIDEO_AHB_CLK, GCC_CAMERA_AHB_CLK,
2507+
* GCC_DISP_AHB_CLK, GCC_GPU_CFG_AHB_CLK
25242508
*/
25252509
regmap_update_bits(regmap, 0x48004, BIT(0), BIT(0));
25262510
regmap_update_bits(regmap, 0x0b004, BIT(0), BIT(0));
2511+
regmap_update_bits(regmap, 0x0b008, BIT(0), BIT(0));
25272512
regmap_update_bits(regmap, 0x0b00c, BIT(0), BIT(0));
25282513
regmap_update_bits(regmap, 0x71004, BIT(0), BIT(0));
25292514

0 commit comments

Comments
 (0)