Skip to content

Commit 98f3e84

Browse files
committed
Merge tag 'dma-mapping-5.17-1' of git://git.infradead.org/users/hch/dma-mapping
Pull dma-mapping fix from Christoph Hellwig: - fix a swiotlb info leak (Halil Pasic) * tag 'dma-mapping-5.17-1' of git://git.infradead.org/users/hch/dma-mapping: swiotlb: fix info leak with DMA_FROM_DEVICE
2 parents 6676ba2 + ddbd89d commit 98f3e84

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

Documentation/core-api/dma-attributes.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,3 +130,11 @@ accesses to DMA buffers in both privileged "supervisor" and unprivileged
130130
subsystem that the buffer is fully accessible at the elevated privilege
131131
level (and ideally inaccessible or at least read-only at the
132132
lesser-privileged levels).
133+
134+
DMA_ATTR_OVERWRITE
135+
------------------
136+
137+
This is a hint to the DMA-mapping subsystem that the device is expected to
138+
overwrite the entire mapped size, thus the caller does not require any of the
139+
previous buffer contents to be preserved. This allows bounce-buffering
140+
implementations to optimise DMA_FROM_DEVICE transfers.

include/linux/dma-mapping.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,14 @@
6161
*/
6262
#define DMA_ATTR_PRIVILEGED (1UL << 9)
6363

64+
/*
65+
* This is a hint to the DMA-mapping subsystem that the device is expected
66+
* to overwrite the entire mapped size, thus the caller does not require any
67+
* of the previous buffer contents to be preserved. This allows
68+
* bounce-buffering implementations to optimise DMA_FROM_DEVICE transfers.
69+
*/
70+
#define DMA_ATTR_OVERWRITE (1UL << 10)
71+
6472
/*
6573
* A dma_addr_t can hold any valid DMA or bus address for the platform. It can
6674
* be given to a device to use as a DMA source or target. It is specific to a

kernel/dma/swiotlb.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,8 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr,
628628
mem->slots[index + i].orig_addr = slot_addr(orig_addr, i);
629629
tlb_addr = slot_addr(mem->start, index) + offset;
630630
if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) &&
631-
(dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL))
631+
(!(attrs & DMA_ATTR_OVERWRITE) || dir == DMA_TO_DEVICE ||
632+
dir == DMA_BIDIRECTIONAL))
632633
swiotlb_bounce(dev, tlb_addr, mapping_size, DMA_TO_DEVICE);
633634
return tlb_addr;
634635
}

0 commit comments

Comments
 (0)