Skip to content

Commit 991df3d

Browse files
sreekanthbrcmmartinkpetersen
authored andcommitted
scsi: mpt3sas: Fix use-after-free warning
Fix the following use-after-free warning which is observed during controller reset: refcount_t: underflow; use-after-free. WARNING: CPU: 23 PID: 5399 at lib/refcount.c:28 refcount_warn_saturate+0xa6/0xf0 Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sreekanth Reddy <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 8fe4ce5 commit 991df3d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/scsi/mpt3sas/mpt3sas_scsih.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3670,6 +3670,7 @@ static struct fw_event_work *dequeue_next_fw_event(struct MPT3SAS_ADAPTER *ioc)
36703670
fw_event = list_first_entry(&ioc->fw_event_list,
36713671
struct fw_event_work, list);
36723672
list_del_init(&fw_event->list);
3673+
fw_event_work_put(fw_event);
36733674
}
36743675
spin_unlock_irqrestore(&ioc->fw_event_lock, flags);
36753676

@@ -3751,7 +3752,6 @@ _scsih_fw_event_cleanup_queue(struct MPT3SAS_ADAPTER *ioc)
37513752
if (cancel_work_sync(&fw_event->work))
37523753
fw_event_work_put(fw_event);
37533754

3754-
fw_event_work_put(fw_event);
37553755
}
37563756
ioc->fw_events_cleanup = 0;
37573757
}

0 commit comments

Comments
 (0)