Skip to content

Commit 99311b8

Browse files
committed
spi: atmel-quadspi: Fix uninitialized res
Merge series from Jinjie Ruan <[email protected]>: Fix uninitialized res in probe function.
2 parents 11543f5 + 2d3e635 commit 99311b8

File tree

1 file changed

+14
-17
lines changed

1 file changed

+14
-17
lines changed

drivers/spi/atmel-quadspi.c

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -602,17 +602,16 @@ static int atmel_qspi_probe(struct platform_device *pdev)
602602

603603
/* Map the registers */
604604
aq->regs = devm_platform_ioremap_resource_byname(pdev, "qspi_base");
605-
if (IS_ERR(aq->regs)) {
606-
dev_err(&pdev->dev, "missing registers\n");
607-
return PTR_ERR(aq->regs);
608-
}
605+
if (IS_ERR(aq->regs))
606+
return dev_err_probe(&pdev->dev, PTR_ERR(aq->regs),
607+
"missing registers\n");
609608

610609
/* Map the AHB memory */
611-
aq->mem = devm_platform_ioremap_resource_byname(pdev, "qspi_mmap");
612-
if (IS_ERR(aq->mem)) {
613-
dev_err(&pdev->dev, "missing AHB memory\n");
614-
return PTR_ERR(aq->mem);
615-
}
610+
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "qspi_mmap");
611+
aq->mem = devm_ioremap_resource(&pdev->dev, res);
612+
if (IS_ERR(aq->mem))
613+
return dev_err_probe(&pdev->dev, PTR_ERR(aq->mem),
614+
"missing AHB memory\n");
616615

617616
aq->mmap_size = resource_size(res);
618617

@@ -621,17 +620,15 @@ static int atmel_qspi_probe(struct platform_device *pdev)
621620
if (IS_ERR(aq->pclk))
622621
aq->pclk = devm_clk_get(&pdev->dev, NULL);
623622

624-
if (IS_ERR(aq->pclk)) {
625-
dev_err(&pdev->dev, "missing peripheral clock\n");
626-
return PTR_ERR(aq->pclk);
627-
}
623+
if (IS_ERR(aq->pclk))
624+
return dev_err_probe(&pdev->dev, PTR_ERR(aq->pclk),
625+
"missing peripheral clock\n");
628626

629627
/* Enable the peripheral clock */
630628
err = clk_prepare_enable(aq->pclk);
631-
if (err) {
632-
dev_err(&pdev->dev, "failed to enable the peripheral clock\n");
633-
return err;
634-
}
629+
if (err)
630+
return dev_err_probe(&pdev->dev, err,
631+
"failed to enable the peripheral clock\n");
635632

636633
aq->caps = of_device_get_match_data(&pdev->dev);
637634
if (!aq->caps) {

0 commit comments

Comments
 (0)