Skip to content

Commit 99b3886

Browse files
superm1alexdeucher
authored andcommitted
drm/amd: Make lack of ACPI_FADT_LOW_POWER_S0 or CONFIG_AMD_PMC louder during suspend path
Users have reported that s2idle wasn't working on OEM Phoenix systems, but it was root caused to be because `CONFIG_AMD_PMC` wasn't set in the distribution kernel config. To make this more apparent, raise the messaging to err instead of warn. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217497 Reviewed-by: Alex Deucher <[email protected]> Signed-off-by: Mario Limonciello <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 38e4ced commit 99b3886

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1093,14 +1093,14 @@ bool amdgpu_acpi_is_s0ix_active(struct amdgpu_device *adev)
10931093
* in that case.
10941094
*/
10951095
if (!(acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0)) {
1096-
dev_warn_once(adev->dev,
1096+
dev_err_once(adev->dev,
10971097
"Power consumption will be higher as BIOS has not been configured for suspend-to-idle.\n"
10981098
"To use suspend-to-idle change the sleep mode in BIOS setup.\n");
10991099
return false;
11001100
}
11011101

11021102
#if !IS_ENABLED(CONFIG_AMD_PMC)
1103-
dev_warn_once(adev->dev,
1103+
dev_err_once(adev->dev,
11041104
"Power consumption will be higher as the kernel has not been compiled with CONFIG_AMD_PMC.\n");
11051105
return false;
11061106
#else

0 commit comments

Comments
 (0)