Skip to content

Commit 9a12a5a

Browse files
committed
Merge tag 'perf-tools-fixes-for-v5.16-2022-01-09' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux
Pull perf tools fixes from Arnaldo Carvalho de Melo: - Revert "libtraceevent: Increase libtraceevent logging when verbose", breaks the build with libtraceevent-1.3.0, i.e. when building with 'LIBTRACEEVENT_DYNAMIC=1'. - Avoid early exit in 'perf trace' due to running SIGCHLD handler before it makes sense to. It can happen when using a BPF source code event that have to be first built into an object file. * tag 'perf-tools-fixes-for-v5.16-2022-01-09' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux: Revert "libtraceevent: Increase libtraceevent logging when verbose" perf trace: Avoid early exit due to running SIGCHLD handler before it makes sense to
2 parents df5bc0a + dc9f2dd commit 9a12a5a

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

tools/perf/builtin-trace.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3925,6 +3925,7 @@ static int trace__run(struct trace *trace, int argc, const char **argv)
39253925
bool draining = false;
39263926

39273927
trace->live = true;
3928+
signal(SIGCHLD, sig_handler);
39283929

39293930
if (!trace->raw_augmented_syscalls) {
39303931
if (trace->trace_syscalls && trace__add_syscall_newtp(trace))
@@ -4873,7 +4874,6 @@ int cmd_trace(int argc, const char **argv)
48734874

48744875
signal(SIGSEGV, sighandler_dump_stack);
48754876
signal(SIGFPE, sighandler_dump_stack);
4876-
signal(SIGCHLD, sig_handler);
48774877
signal(SIGINT, sig_handler);
48784878

48794879
trace.evlist = evlist__new();

tools/perf/util/debug.c

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,6 @@
2424
#include "util/parse-sublevel-options.h"
2525

2626
#include <linux/ctype.h>
27-
#include <traceevent/event-parse.h>
28-
29-
#define MAKE_LIBTRACEEVENT_VERSION(a, b, c) ((a)*255*255+(b)*255+(c))
30-
#ifndef LIBTRACEEVENT_VERSION
31-
/*
32-
* If LIBTRACEEVENT_VERSION wasn't computed then set to version 1.1.0 that ships
33-
* with the Linux kernel tools.
34-
*/
35-
#define LIBTRACEEVENT_VERSION MAKE_LIBTRACEEVENT_VERSION(1, 1, 0)
36-
#endif
3727

3828
int verbose;
3929
int debug_peo_args;
@@ -238,15 +228,6 @@ int perf_debug_option(const char *str)
238228
/* Allow only verbose value in range (0, 10), otherwise set 0. */
239229
verbose = (verbose < 0) || (verbose > 10) ? 0 : verbose;
240230

241-
#if MAKE_LIBTRACEEVENT_VERSION(1, 3, 0) <= LIBTRACEEVENT_VERSION
242-
if (verbose == 1)
243-
tep_set_loglevel(TEP_LOG_INFO);
244-
else if (verbose == 2)
245-
tep_set_loglevel(TEP_LOG_DEBUG);
246-
else if (verbose >= 3)
247-
tep_set_loglevel(TEP_LOG_ALL);
248-
#endif
249-
250231
return 0;
251232
}
252233

0 commit comments

Comments
 (0)