Skip to content

Commit 9a267ce

Browse files
committed
wifi: mac80211: fix SA Query processing in MLO
When MLO is used and SA Query processing isn't done by userspace (e.g. wpa_supplicant w/o CONFIG_OCV), then the mac80211 code kicks in but uses the wrong addresses. Fix them. Signed-off-by: Johannes Berg <[email protected]> Reviewed-by: Ilan Peer <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://patch.msgid.link/20250306123626.bab48bb49061.I9391b22f1360d20ac8c4e92604de23f27696ba8f@changeid Signed-off-by: Johannes Berg <[email protected]>
1 parent 2e85829 commit 9a267ce

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

net/mac80211/rx.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* Copyright 2007-2010 Johannes Berg <[email protected]>
77
* Copyright 2013-2014 Intel Mobile Communications GmbH
88
* Copyright(c) 2015 - 2017 Intel Deutschland GmbH
9-
* Copyright (C) 2018-2024 Intel Corporation
9+
* Copyright (C) 2018-2025 Intel Corporation
1010
*/
1111

1212
#include <linux/jiffies.h>
@@ -3329,8 +3329,8 @@ static void ieee80211_process_sa_query_req(struct ieee80211_sub_if_data *sdata,
33293329
return;
33303330
}
33313331

3332-
if (!ether_addr_equal(mgmt->sa, sdata->deflink.u.mgd.bssid) ||
3333-
!ether_addr_equal(mgmt->bssid, sdata->deflink.u.mgd.bssid)) {
3332+
if (!ether_addr_equal(mgmt->sa, sdata->vif.cfg.ap_addr) ||
3333+
!ether_addr_equal(mgmt->bssid, sdata->vif.cfg.ap_addr)) {
33343334
/* Not from the current AP or not associated yet. */
33353335
return;
33363336
}
@@ -3346,9 +3346,9 @@ static void ieee80211_process_sa_query_req(struct ieee80211_sub_if_data *sdata,
33463346

33473347
skb_reserve(skb, local->hw.extra_tx_headroom);
33483348
resp = skb_put_zero(skb, 24);
3349-
memcpy(resp->da, mgmt->sa, ETH_ALEN);
3349+
memcpy(resp->da, sdata->vif.cfg.ap_addr, ETH_ALEN);
33503350
memcpy(resp->sa, sdata->vif.addr, ETH_ALEN);
3351-
memcpy(resp->bssid, sdata->deflink.u.mgd.bssid, ETH_ALEN);
3351+
memcpy(resp->bssid, sdata->vif.cfg.ap_addr, ETH_ALEN);
33523352
resp->frame_control = cpu_to_le16(IEEE80211_FTYPE_MGMT |
33533353
IEEE80211_STYPE_ACTION);
33543354
skb_put(skb, 1 + sizeof(resp->u.action.u.sa_query));

0 commit comments

Comments
 (0)