Skip to content

Commit 9a5e69c

Browse files
Li Zetaomchehab
authored andcommitted
media: atomisp: use clamp() in compute_coring()
When it needs to get a value within a certain interval, using clamp() makes the code easier to understand than min(max()). Signed-off-by: Li Zetao <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 7adc719 commit 9a5e69c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ compute_coring(int coring)
108108
* factor. Clip to [0, isp_scale-1).
109109
*/
110110
isp_coring = ((coring * isp_scale) + offset) / host_scale;
111-
return min(max(isp_coring, 0), isp_scale - 1);
111+
return clamp(isp_coring, 0, isp_scale - 1);
112112
}
113113

114114
/*
@@ -168,15 +168,15 @@ ia_css_xnr3_encode(
168168
to->alpha.y0 = alpha_y0;
169169
to->alpha.u0 = alpha_u0;
170170
to->alpha.v0 = alpha_v0;
171-
to->alpha.ydiff = min(max(alpha_ydiff, min_diff), max_diff);
172-
to->alpha.udiff = min(max(alpha_udiff, min_diff), max_diff);
173-
to->alpha.vdiff = min(max(alpha_vdiff, min_diff), max_diff);
171+
to->alpha.ydiff = clamp(alpha_ydiff, min_diff, max_diff);
172+
to->alpha.udiff = clamp(alpha_udiff, min_diff, max_diff);
173+
to->alpha.vdiff = clamp(alpha_vdiff, min_diff, max_diff);
174174

175175
/* coring parameters are expressed in q1.NN format */
176176
to->coring.u0 = coring_u0;
177177
to->coring.v0 = coring_v0;
178-
to->coring.udiff = min(max(coring_udiff, min_diff), max_diff);
179-
to->coring.vdiff = min(max(coring_vdiff, min_diff), max_diff);
178+
to->coring.udiff = clamp(coring_udiff, min_diff, max_diff);
179+
to->coring.vdiff = clamp(coring_vdiff, min_diff, max_diff);
180180

181181
/* blending strength is expressed in q1.NN format */
182182
to->blending.strength = blending;

0 commit comments

Comments
 (0)