umem: remove redundant initialization of variable ret

Colin Ian King · axboe · commit 9a6a5738abf8 · 2020-06-11T09:16:17.000-06:00
The variable ret is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Addresses-Coverity: ("Unused value")
Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/drivers/block/umem.c b/drivers/block/umem.c
@@ -784,7 +784,7 @@ static const struct block_device_operations mm_fops = {
 
 static int mm_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 {
-	int ret = -ENODEV;
+	int ret;
 	struct cardinfo *card = &cards[num_cards];
 	unsigned char	mem_present;
 	unsigned char	batt_status;

Original file line number	Diff line number	Diff line change
`@@ -784,7 +784,7 @@ static const struct block_device_operations mm_fops = {`
`784`	`784`
`785`	`785`	`static int mm_pci_probe(struct pci_dev dev, const struct pci_device_id id)`
`786`	`786`	`{`
`787`		`- int ret = -ENODEV;`
	`787`	`+ int ret;`
`788`	`788`	`struct cardinfo *card = &cards[num_cards];`
`789`	`789`	`unsigned char mem_present;`
`790`	`790`	`unsigned char batt_status;`