NFS: remove redundant initialization of variable result

Colin Ian King · Trond Myklebust · commit 9a74a2b87f4c · 2020-07-28T11:04:06.000-04:00
The variable result is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@hammerspace.com&gt;
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
@@ -901,7 +901,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
  */
 ssize_t nfs_file_direct_write(struct kiocb *iocb, struct iov_iter *iter)
 {
-	ssize_t result = -EINVAL, requested;
+	ssize_t result, requested;
 	size_t count;
 	struct file *file = iocb->ki_filp;
 	struct address_space *mapping = file->f_mapping;

Original file line number	Diff line number	Diff line change
`@@ -901,7 +901,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,`
`901`	`901`	`*/`
`902`	`902`	`ssize_t nfs_file_direct_write(struct kiocb iocb, struct iov_iter iter)`
`903`	`903`	`{`
`904`		`- ssize_t result = -EINVAL, requested;`
	`904`	`+ ssize_t result, requested;`
`905`	`905`	`size_t count;`
`906`	`906`	`struct file *file = iocb->ki_filp;`
`907`	`907`	`struct address_space *mapping = file->f_mapping;`