Skip to content

Commit 9a996c6

Browse files
committed
s390/vmemmap: coding style updates
Signed-off-by: Heiko Carstens <[email protected]>
1 parent 2c114df commit 9a996c6

File tree

1 file changed

+20
-35
lines changed

1 file changed

+20
-35
lines changed

arch/s390/mm/vmem.c

Lines changed: 20 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -169,17 +169,17 @@ static int __ref modify_pte_table(pmd_t *pmd, unsigned long addr,
169169
pte_clear(&init_mm, addr, pte);
170170
} else if (pte_none(*pte)) {
171171
if (!direct) {
172-
void *new_page = vmemmap_alloc_block(PAGE_SIZE,
173-
NUMA_NO_NODE);
172+
void *new_page = vmemmap_alloc_block(PAGE_SIZE, NUMA_NO_NODE);
174173

175174
if (!new_page)
176175
goto out;
177176
pte_val(*pte) = __pa(new_page) | prot;
178-
} else
177+
} else {
179178
pte_val(*pte) = addr | prot;
180-
} else
179+
}
180+
} else {
181181
continue;
182-
182+
}
183183
pages++;
184184
}
185185
ret = 0;
@@ -196,10 +196,10 @@ static void try_free_pte_table(pmd_t *pmd, unsigned long start)
196196

197197
/* We can safely assume this is fully in 1:1 mapping & vmemmap area */
198198
pte = pte_offset_kernel(pmd, start);
199-
for (i = 0; i < PTRS_PER_PTE; i++, pte++)
199+
for (i = 0; i < PTRS_PER_PTE; i++, pte++) {
200200
if (!pte_none(*pte))
201201
return;
202-
202+
}
203203
vmem_pte_free(__va(pmd_deref(*pmd)));
204204
pmd_clear(pmd);
205205
}
@@ -220,22 +220,18 @@ static int __ref modify_pmd_table(pud_t *pud, unsigned long addr,
220220
pmd = pmd_offset(pud, addr);
221221
for (; addr < end; addr = next, pmd++) {
222222
next = pmd_addr_end(addr, end);
223-
224223
if (!add) {
225224
if (pmd_none(*pmd))
226225
continue;
227226
if (pmd_large(*pmd) && !add) {
228227
if (IS_ALIGNED(addr, PMD_SIZE) &&
229228
IS_ALIGNED(next, PMD_SIZE)) {
230229
if (!direct)
231-
vmem_free_pages(pmd_deref(*pmd),
232-
get_order(PMD_SIZE));
230+
vmem_free_pages(pmd_deref(*pmd), get_order(PMD_SIZE));
233231
pmd_clear(pmd);
234232
pages++;
235-
} else if (!direct &&
236-
vmemmap_unuse_sub_pmd(addr, next)) {
237-
vmem_free_pages(pmd_deref(*pmd),
238-
get_order(PMD_SIZE));
233+
} else if (!direct && vmemmap_unuse_sub_pmd(addr, next)) {
234+
vmem_free_pages(pmd_deref(*pmd), get_order(PMD_SIZE));
239235
pmd_clear(pmd);
240236
}
241237
continue;
@@ -258,14 +254,12 @@ static int __ref modify_pmd_table(pud_t *pud, unsigned long addr,
258254
* page tables since vmemmap_populate gets
259255
* called for each section separately.
260256
*/
261-
new_page = vmemmap_alloc_block(PMD_SIZE,
262-
NUMA_NO_NODE);
257+
new_page = vmemmap_alloc_block(PMD_SIZE, NUMA_NO_NODE);
263258
if (new_page) {
264259
pmd_val(*pmd) = __pa(new_page) | prot;
265260
if (!IS_ALIGNED(addr, PMD_SIZE) ||
266261
!IS_ALIGNED(next, PMD_SIZE)) {
267-
vmemmap_use_new_sub_pmd(addr,
268-
next);
262+
vmemmap_use_new_sub_pmd(addr, next);
269263
}
270264
continue;
271265
}
@@ -279,7 +273,6 @@ static int __ref modify_pmd_table(pud_t *pud, unsigned long addr,
279273
vmemmap_use_sub_pmd(addr, next);
280274
continue;
281275
}
282-
283276
ret = modify_pte_table(pmd, addr, next, add, direct);
284277
if (ret)
285278
goto out;
@@ -306,12 +299,10 @@ static void try_free_pmd_table(pud_t *pud, unsigned long start)
306299
if (start < KASAN_SHADOW_END && KASAN_SHADOW_START > end)
307300
return;
308301
#endif
309-
310302
pmd = pmd_offset(pud, start);
311303
for (i = 0; i < PTRS_PER_PMD; i++, pmd++)
312304
if (!pmd_none(*pmd))
313305
return;
314-
315306
vmem_free_pages(pud_deref(*pud), CRST_ALLOC_ORDER);
316307
pud_clear(pud);
317308
}
@@ -327,11 +318,9 @@ static int modify_pud_table(p4d_t *p4d, unsigned long addr, unsigned long end,
327318
prot = pgprot_val(REGION3_KERNEL);
328319
if (!MACHINE_HAS_NX)
329320
prot &= ~_REGION_ENTRY_NOEXEC;
330-
331321
pud = pud_offset(p4d, addr);
332322
for (; addr < end; addr = next, pud++) {
333323
next = pud_addr_end(addr, end);
334-
335324
if (!add) {
336325
if (pud_none(*pud))
337326
continue;
@@ -356,9 +345,9 @@ static int modify_pud_table(p4d_t *p4d, unsigned long addr, unsigned long end,
356345
if (!pmd)
357346
goto out;
358347
pud_populate(&init_mm, pud, pmd);
359-
} else if (pud_large(*pud))
348+
} else if (pud_large(*pud)) {
360349
continue;
361-
350+
}
362351
ret = modify_pmd_table(pud, addr, next, add, direct);
363352
if (ret)
364353
goto out;
@@ -387,10 +376,10 @@ static void try_free_pud_table(p4d_t *p4d, unsigned long start)
387376
#endif
388377

389378
pud = pud_offset(p4d, start);
390-
for (i = 0; i < PTRS_PER_PUD; i++, pud++)
379+
for (i = 0; i < PTRS_PER_PUD; i++, pud++) {
391380
if (!pud_none(*pud))
392381
return;
393-
382+
}
394383
vmem_free_pages(p4d_deref(*p4d), CRST_ALLOC_ORDER);
395384
p4d_clear(p4d);
396385
}
@@ -406,7 +395,6 @@ static int modify_p4d_table(pgd_t *pgd, unsigned long addr, unsigned long end,
406395
p4d = p4d_offset(pgd, addr);
407396
for (; addr < end; addr = next, p4d++) {
408397
next = p4d_addr_end(addr, end);
409-
410398
if (!add) {
411399
if (p4d_none(*p4d))
412400
continue;
@@ -415,7 +403,6 @@ static int modify_p4d_table(pgd_t *pgd, unsigned long addr, unsigned long end,
415403
if (!pud)
416404
goto out;
417405
}
418-
419406
ret = modify_pud_table(p4d, addr, next, add, direct);
420407
if (ret)
421408
goto out;
@@ -442,10 +429,10 @@ static void try_free_p4d_table(pgd_t *pgd, unsigned long start)
442429
#endif
443430

444431
p4d = p4d_offset(pgd, start);
445-
for (i = 0; i < PTRS_PER_P4D; i++, p4d++)
432+
for (i = 0; i < PTRS_PER_P4D; i++, p4d++) {
446433
if (!p4d_none(*p4d))
447434
return;
448-
435+
}
449436
vmem_free_pages(pgd_deref(*pgd), CRST_ALLOC_ORDER);
450437
pgd_clear(pgd);
451438
}
@@ -460,7 +447,6 @@ static int modify_pagetable(unsigned long start, unsigned long end, bool add,
460447

461448
if (WARN_ON_ONCE(!PAGE_ALIGNED(start | end)))
462449
return -EINVAL;
463-
464450
for (addr = start; addr < end; addr = next) {
465451
next = pgd_addr_end(addr, end);
466452
pgd = pgd_offset_k(addr);
@@ -474,7 +460,6 @@ static int modify_pagetable(unsigned long start, unsigned long end, bool add,
474460
goto out;
475461
pgd_populate(&init_mm, pgd, p4d);
476462
}
477-
478463
ret = modify_p4d_table(pgd, addr, next, add, direct);
479464
if (ret)
480465
goto out;
@@ -518,7 +503,7 @@ static void vmem_remove_range(unsigned long start, unsigned long size)
518503
* Add a backed mem_map array to the virtual mem_map array.
519504
*/
520505
int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node,
521-
struct vmem_altmap *altmap)
506+
struct vmem_altmap *altmap)
522507
{
523508
int ret;
524509

@@ -532,7 +517,7 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node,
532517
}
533518

534519
void vmemmap_free(unsigned long start, unsigned long end,
535-
struct vmem_altmap *altmap)
520+
struct vmem_altmap *altmap)
536521
{
537522
mutex_lock(&vmem_mutex);
538523
remove_pagetable(start, end, false);

0 commit comments

Comments
 (0)