Skip to content

Commit 9b72324

Browse files
author
Thomas Zimmermann
committed
drm/fb-helper: Remove test for fb_dirty callback from deferred-I/O helper
The helper for processing deferred I/O on pages has no dependency on the fb_dirty damge-handling callback; so remove the test. In practice, deferred I/O is only used with damage handling and the damage worker already guarantees the presence of the fb_dirty callback. Signed-off-by: Thomas Zimmermann <[email protected]> Reviewed-by: Daniel Vetter <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 17d64f1 commit 9b72324

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

drivers/gpu/drm/drm_fb_helper.c

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -656,17 +656,15 @@ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagerefli
656656
min_off = min(min_off, start);
657657
max_off = max(max_off, end);
658658
}
659-
if (min_off >= max_off)
660-
return;
661659

662-
if (helper->funcs->fb_dirty) {
663-
/*
664-
* As we can only track pages, we might reach beyond the end
665-
* of the screen and account for non-existing scanlines. Hence,
666-
* keep the covered memory area within the screen buffer.
667-
*/
668-
max_off = min(max_off, info->screen_size);
660+
/*
661+
* As we can only track pages, we might reach beyond the end
662+
* of the screen and account for non-existing scanlines. Hence,
663+
* keep the covered memory area within the screen buffer.
664+
*/
665+
max_off = min(max_off, info->screen_size);
669666

667+
if (min_off < max_off) {
670668
drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area);
671669
drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
672670
drm_rect_width(&damage_area),

0 commit comments

Comments
 (0)