Skip to content

Commit 9b78d91

Browse files
author
Paolo Abeni
committed
net: phy: hide the PHYLIB_LEDS knob
commit 4bb7aac ("net: phy: fix circular LEDS_CLASS dependencies") solved a build failure, but introduces a new config knob with a default 'y' value: PHYLIB_LEDS. The latter is against the current new config policy. The exception was raised to allow the user to catch bad configurations without led support. Anyway the current definition of PHYLIB_LEDS does not fit the above goal: if LEDS_CLASS is disabled, the new config will be available only with PHYLIB disabled, too. Hide the mentioned config, to preserve the randconfig testing done so far, while respecting the mentioned policy. Suggested-by: Andrew Lunn <[email protected]> Suggested-by: Arnd Bergmann <[email protected]> Signed-off-by: Paolo Abeni <[email protected]> Link: https://lore.kernel.org/r/d82489be8ed911c383c3447e9abf469995ccf39a.1682496488.git.pabeni@redhat.com Signed-off-by: Paolo Abeni <[email protected]>
1 parent c248b27 commit 9b78d91

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/net/phy/Kconfig

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,8 @@ config LED_TRIGGER_PHY
4545
for any speed known to the PHY.
4646

4747
config PHYLIB_LEDS
48-
bool "Support probing LEDs from device tree"
48+
def_bool OF
4949
depends on LEDS_CLASS=y || LEDS_CLASS=PHYLIB
50-
depends on OF
51-
default y
5250
help
5351
When LED class support is enabled, phylib can automatically
5452
probe LED setting from device tree.

0 commit comments

Comments
 (0)