Skip to content

Commit 9bed667

Browse files
qzedjwrdegoede
authored andcommitted
platform/surface: aggregator_tabletsw: Add support for book mode in KIP subsystem
Devices with a type-cover have an additional "book" mode, deactivating type-cover input and turning off its backlight. This is currently unsupported, leading to the warning surface_aggregator_tablet_mode_switch 01:0e:01:00:01: unknown KIP cover state: 6 Therefore, add support for this state and map it to enable tablet-mode. Fixes: 9f79405 ("platform/surface: Add KIP/POS tablet-mode switch driver") Signed-off-by: Maximilian Luz <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Hans de Goede <[email protected]> Signed-off-by: Hans de Goede <[email protected]>
1 parent 539e0a7 commit 9bed667

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/platform/surface/surface_aggregator_tabletsw.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ enum ssam_kip_cover_state {
210210
SSAM_KIP_COVER_STATE_LAPTOP = 0x03,
211211
SSAM_KIP_COVER_STATE_FOLDED_CANVAS = 0x04,
212212
SSAM_KIP_COVER_STATE_FOLDED_BACK = 0x05,
213+
SSAM_KIP_COVER_STATE_BOOK = 0x06,
213214
};
214215

215216
static const char *ssam_kip_cover_state_name(struct ssam_tablet_sw *sw,
@@ -231,6 +232,9 @@ static const char *ssam_kip_cover_state_name(struct ssam_tablet_sw *sw,
231232
case SSAM_KIP_COVER_STATE_FOLDED_BACK:
232233
return "folded-back";
233234

235+
case SSAM_KIP_COVER_STATE_BOOK:
236+
return "book";
237+
234238
default:
235239
dev_warn(&sw->sdev->dev, "unknown KIP cover state: %u\n", state->state);
236240
return "<unknown>";
@@ -244,6 +248,7 @@ static bool ssam_kip_cover_state_is_tablet_mode(struct ssam_tablet_sw *sw,
244248
case SSAM_KIP_COVER_STATE_DISCONNECTED:
245249
case SSAM_KIP_COVER_STATE_FOLDED_CANVAS:
246250
case SSAM_KIP_COVER_STATE_FOLDED_BACK:
251+
case SSAM_KIP_COVER_STATE_BOOK:
247252
return true;
248253

249254
case SSAM_KIP_COVER_STATE_CLOSED:

0 commit comments

Comments
 (0)