Skip to content

Commit 9bedf10

Browse files
committed
Merge tag 'spi-fix-v5.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi
Pull spi modalias fix from Mark Brown: "Fix modalias issues As reported by Russell King the change to use OF style modaliases for DT enumerated broke at least the spi-nor driver, the patch here reverts that change to fix the regression. Sadly this will mean that anything that started loading since the change to OF modaliases will run into issues, there doesn't seem to be any approach which doesn't cause some problems and thi seems like the least bad approach - gory details are in the commit log for the change. I'm currently working through the SPI drivers to add ID tables and missing IDs to tables which should address things from the other end, this seems more straightforward and robust than any other options" * tag 'spi-fix-v5.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi: spi: Revert modalias changes
2 parents cf1d2c3 + 96c8395 commit 9bedf10

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/spi/spi.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf)
5858
const struct spi_device *spi = to_spi_device(dev);
5959
int len;
6060

61-
len = of_device_modalias(dev, buf, PAGE_SIZE);
62-
if (len != -ENODEV)
63-
return len;
64-
6561
len = acpi_device_modalias(dev, buf, PAGE_SIZE - 1);
6662
if (len != -ENODEV)
6763
return len;
@@ -367,10 +363,6 @@ static int spi_uevent(struct device *dev, struct kobj_uevent_env *env)
367363
const struct spi_device *spi = to_spi_device(dev);
368364
int rc;
369365

370-
rc = of_device_uevent_modalias(dev, env);
371-
if (rc != -ENODEV)
372-
return rc;
373-
374366
rc = acpi_device_uevent_modalias(dev, env);
375367
if (rc != -ENODEV)
376368
return rc;

0 commit comments

Comments
 (0)