Skip to content

Commit 9c79b77

Browse files
arndbvinodkoul
authored andcommitted
phy: rockchip: fix CONFIG_TYPEC dependency
The newly added driver causes a warning about missing dependencies by selecting CONFIG_TYPEC unconditionally: WARNING: unmet direct dependencies detected for TYPEC Depends on [n]: USB_SUPPORT [=n] Selected by [y]: - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] WARNING: unmet direct dependencies detected for USB_COMMON Depends on [n]: USB_SUPPORT [=n] Selected by [y]: - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y] Since that is a user-visible option, it should not really be selected in the first place. Replace the 'select' with a 'depends on' as we have for similar drivers. Fixes: 2f70bbd ("phy: rockchip: add usbdp combo phy driver") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Heiko Stuebner <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent c9342d1 commit 9c79b77

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/phy/rockchip/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ config PHY_ROCKCHIP_USB
119119
config PHY_ROCKCHIP_USBDP
120120
tristate "Rockchip USBDP COMBO PHY Driver"
121121
depends on ARCH_ROCKCHIP && OF
122+
depends on TYPEC
122123
select GENERIC_PHY
123-
select TYPEC
124124
help
125125
Enable this to support the Rockchip USB3.0/DP combo PHY with
126126
Samsung IP block. This is required for USB3 support on RK3588.

0 commit comments

Comments
 (0)