Skip to content

Commit 9c7c4bc

Browse files
Ming Leiaxboe
authored andcommitted
ublk: remove check IO_URING_F_SQE128 in ublk_ch_uring_cmd
sizeof(struct ublksrv_io_cmd) is 16bytes, which can be held in 64byte SQE, so not necessary to check IO_URING_F_SQE128. With this change, we get chance to save half SQ ring memory. Fixed: 71f28f3 ("ublk_drv: add io_uring based userspace block driver") Signed-off-by: Ming Lei <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 9e0c7ef commit 9c7c4bc

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/block/ublk_drv.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1271,9 +1271,6 @@ static int ublk_ch_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags)
12711271
__func__, cmd->cmd_op, ub_cmd->q_id, tag,
12721272
ub_cmd->result);
12731273

1274-
if (!(issue_flags & IO_URING_F_SQE128))
1275-
goto out;
1276-
12771274
if (ub_cmd->q_id >= ub->dev_info.nr_hw_queues)
12781275
goto out;
12791276

0 commit comments

Comments
 (0)