Skip to content

Commit 9cd6b59

Browse files
committed
fs-verity: remove unnecessary extern keywords
Remove the unnecessary 'extern' keywords from function declarations. This makes it so that we don't have a mix of both styles, so it won't be ambiguous what to use in new fs-verity patches. This also makes the code shorter and matches the 'checkpatch --strict' expectation. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Eric Biggers <[email protected]>
1 parent 6377a38 commit 9cd6b59

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

fs/verity/fsverity_private.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ void __init fsverity_check_hash_algs(void);
134134

135135
/* init.c */
136136

137-
extern void __printf(3, 4) __cold
137+
void __printf(3, 4) __cold
138138
fsverity_msg(const struct inode *inode, const char *level,
139139
const char *fmt, ...);
140140

include/linux/fsverity.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -121,23 +121,23 @@ static inline struct fsverity_info *fsverity_get_info(const struct inode *inode)
121121

122122
/* enable.c */
123123

124-
extern int fsverity_ioctl_enable(struct file *filp, const void __user *arg);
124+
int fsverity_ioctl_enable(struct file *filp, const void __user *arg);
125125

126126
/* measure.c */
127127

128-
extern int fsverity_ioctl_measure(struct file *filp, void __user *arg);
128+
int fsverity_ioctl_measure(struct file *filp, void __user *arg);
129129

130130
/* open.c */
131131

132-
extern int fsverity_file_open(struct inode *inode, struct file *filp);
133-
extern int fsverity_prepare_setattr(struct dentry *dentry, struct iattr *attr);
134-
extern void fsverity_cleanup_inode(struct inode *inode);
132+
int fsverity_file_open(struct inode *inode, struct file *filp);
133+
int fsverity_prepare_setattr(struct dentry *dentry, struct iattr *attr);
134+
void fsverity_cleanup_inode(struct inode *inode);
135135

136136
/* verify.c */
137137

138-
extern bool fsverity_verify_page(struct page *page);
139-
extern void fsverity_verify_bio(struct bio *bio);
140-
extern void fsverity_enqueue_verify_work(struct work_struct *work);
138+
bool fsverity_verify_page(struct page *page);
139+
void fsverity_verify_bio(struct bio *bio);
140+
void fsverity_enqueue_verify_work(struct work_struct *work);
141141

142142
#else /* !CONFIG_FS_VERITY */
143143

0 commit comments

Comments
 (0)