Skip to content

Commit 9d0120b

Browse files
krzkgclement
authored andcommitted
ARM: dts: marvell: kirkwood: align LED node name with bindings
Bindings expect the LED node names to follow certain pattern, see dtbs_check warnings: kirkwood-ds409slim.dtb: gpio-leds-alarm-12: 'hdd1-green' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Gregory CLEMENT <[email protected]>
1 parent 28be5af commit 9d0120b

30 files changed

+157
-157
lines changed

arch/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
gpio-leds {
5252
compatible = "gpio-leds";
5353

54-
blue-power {
54+
led-blue-power {
5555
label = "nas220:blue:power";
5656
gpios = <&gpio0 12 GPIO_ACTIVE_HIGH>;
5757
linux,default-trigger = "default-on";

arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@
6969
gpio-leds {
7070
compatible = "gpio-leds";
7171

72-
red-fail {
72+
led-red-fail {
7373
label = "cloudbox:red:fail";
7474
gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
7575
};
76-
blue-sata {
76+
led-blue-sata {
7777
label = "cloudbox:blue:sata";
7878
gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
7979
};

arch/arm/boot/dts/marvell/kirkwood-d2net.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
gpio-leds {
3838
compatible = "gpio-leds";
3939

40-
red-fail {
40+
led-red-fail {
4141
label = "d2net_v2:red:fail";
4242
gpios = <&gpio0 12 GPIO_ACTIVE_HIGH>;
4343
};

arch/arm/boot/dts/marvell/kirkwood-dir665.dts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -137,38 +137,38 @@
137137
gpio-leds {
138138
compatible = "gpio-leds";
139139

140-
blue-usb {
140+
led-blue-usb {
141141
label = "dir665:blue:usb";
142142
gpios = <&gpio0 12 GPIO_ACTIVE_HIGH>;
143143
};
144-
blue-internet {
144+
led-blue-internet {
145145
/* Can only be turned on if the Internet
146146
* Ethernet port has Link
147147
*/
148148
label = "dir665:blue:internet";
149149
gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
150150
};
151-
amber-internet {
151+
led-amber-internet {
152152
label = "dir665:amber:internet";
153153
gpios = <&gpio1 11 GPIO_ACTIVE_HIGH>;
154154
};
155-
blue-wifi5g {
155+
led-blue-wifi5g {
156156
label = "dir665:blue:5g";
157157
gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
158158
};
159-
blue-status {
159+
led-blue-status {
160160
label = "dir665:blue:status";
161161
gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
162162
};
163-
blue-wps {
163+
led-blue-wps {
164164
label = "dir665:blue:wps";
165165
gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
166166
};
167-
amber-status {
167+
led-amber-status {
168168
label = "dir665:amber:status";
169169
gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>;
170170
};
171-
blue-24g {
171+
led-blue-24g {
172172
label = "dir665:blue:24g";
173173
gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
174174
};

arch/arm/boot/dts/marvell/kirkwood-dns320.dts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,24 +24,24 @@
2424
&pmx_led_white_usb>;
2525
pinctrl-names = "default";
2626

27-
blue-power {
27+
led-blue-power {
2828
label = "dns320:blue:power";
2929
gpios = <&gpio0 26 GPIO_ACTIVE_LOW>;
3030
default-state = "keep";
3131
};
32-
blue-usb {
32+
led-blue-usb {
3333
label = "dns320:blue:usb";
3434
gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
3535
};
36-
orange-l_hdd {
36+
led-orange-l_hdd {
3737
label = "dns320:orange:l_hdd";
3838
gpios = <&gpio0 28 GPIO_ACTIVE_LOW>;
3939
};
40-
orange-r_hdd {
40+
led-orange-r_hdd {
4141
label = "dns320:orange:r_hdd";
4242
gpios = <&gpio0 27 GPIO_ACTIVE_LOW>;
4343
};
44-
orange-usb {
44+
led-orange-usb {
4545
label = "dns320:orange:usb";
4646
gpios = <&gpio1 3 GPIO_ACTIVE_LOW>; /* GPIO 35 */
4747
};

arch/arm/boot/dts/marvell/kirkwood-dns325.dts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,24 +24,24 @@
2424
&pmx_led_white_usb>;
2525
pinctrl-names = "default";
2626

27-
white-power {
27+
led-white-power {
2828
label = "dns325:white:power";
2929
gpios = <&gpio0 26 GPIO_ACTIVE_LOW>;
3030
default-state = "keep";
3131
};
32-
white-usb {
32+
led-white-usb {
3333
label = "dns325:white:usb";
3434
gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; /* GPIO 43 */
3535
};
36-
red-l_hdd {
36+
led-red-l_hdd {
3737
label = "dns325:red:l_hdd";
3838
gpios = <&gpio0 28 GPIO_ACTIVE_LOW>;
3939
};
40-
red-r_hdd {
40+
led-red-r_hdd {
4141
label = "dns325:red:r_hdd";
4242
gpios = <&gpio0 27 GPIO_ACTIVE_LOW>;
4343
};
44-
red-usb {
44+
led-red-usb {
4545
label = "dns325:red:usb";
4646
gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
4747
};

arch/arm/boot/dts/marvell/kirkwood-dockstar.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@
4242
pinctrl-0 = <&pmx_led_green &pmx_led_orange>;
4343
pinctrl-names = "default";
4444

45-
health {
45+
led-health {
4646
label = "status:green:health";
4747
gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
4848
default-state = "keep";
4949
};
50-
fault {
50+
led-fault {
5151
label = "status:orange:fault";
5252
gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
5353
};

arch/arm/boot/dts/marvell/kirkwood-dreamplug.dts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,15 @@
8585
&pmx_led_wifi_ap >;
8686
pinctrl-names = "default";
8787

88-
bluetooth {
88+
led-bluetooth {
8989
label = "dreamplug:blue:bluetooth";
9090
gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
9191
};
92-
wifi {
92+
led-wifi {
9393
label = "dreamplug:green:wifi";
9494
gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
9595
};
96-
wifi-ap {
96+
led-wifi-ap {
9797
label = "dreamplug:green:wifi_ap";
9898
gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
9999
};

arch/arm/boot/dts/marvell/kirkwood-goflexnet.dts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,44 +85,44 @@
8585
>;
8686
pinctrl-names = "default";
8787

88-
health {
88+
led-health {
8989
label = "status:green:health";
9090
gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
9191
default-state = "keep";
9292
};
93-
fault {
93+
led-fault {
9494
label = "status:orange:fault";
9595
gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
9696
};
97-
left0 {
97+
led-left0 {
9898
label = "status:white:left0";
9999
gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>;
100100
};
101-
left1 {
101+
led-left1 {
102102
label = "status:white:left1";
103103
gpios = <&gpio1 11 GPIO_ACTIVE_HIGH>;
104104
};
105-
left2 {
105+
led-left2 {
106106
label = "status:white:left2";
107107
gpios = <&gpio1 12 GPIO_ACTIVE_HIGH>;
108108
};
109-
left3 {
109+
led-left3 {
110110
label = "status:white:left3";
111111
gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
112112
};
113-
right0 {
113+
led-right0 {
114114
label = "status:white:right0";
115115
gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
116116
};
117-
right1 {
117+
led-right1 {
118118
label = "status:white:right1";
119119
gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
120120
};
121-
right2 {
121+
led-right2 {
122122
label = "status:white:right2";
123123
gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
124124
};
125-
right3 {
125+
led-right3 {
126126
label = "status:white:right3";
127127
gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
128128
};

arch/arm/boot/dts/marvell/kirkwood-guruplug-server-plus.dts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,19 @@
5959
&pmx_led_wmode_r &pmx_led_wmode_g >;
6060
pinctrl-names = "default";
6161

62-
health-r {
62+
led-health-r {
6363
label = "guruplug:red:health";
6464
gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
6565
};
66-
health-g {
66+
led-health-g {
6767
label = "guruplug:green:health";
6868
gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
6969
};
70-
wmode-r {
70+
led-wmode-r {
7171
label = "guruplug:red:wmode";
7272
gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
7373
};
74-
wmode-g {
74+
led-wmode-g {
7575
label = "guruplug:green:wmode";
7676
gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
7777
};

0 commit comments

Comments
 (0)