Skip to content

Commit 9d44a12

Browse files
rgbriggspcmoore
authored andcommitted
audit: add subj creds to NETFILTER_CFG record to
Some table unregister actions seem to be initiated by the kernel to garbage collect unused tables that are not initiated by any userspace actions. It was found to be necessary to add the subject credentials to cover this case to reveal the source of these actions. A sample record: The uid, auid, tty, ses and exe fields have not been included since they are in the SYSCALL record and contain nothing useful in the non-user context. Here are two sample orphaned records: type=NETFILTER_CFG msg=audit(2020-05-20 12:14:36.505:5) : table=filter family=ipv4 entries=0 op=register pid=1 subj=kernel comm=swapper/0 type=NETFILTER_CFG msg=audit(2020-05-20 12:15:27.701:301) : table=nat family=bridge entries=0 op=unregister pid=30 subj=system_u:system_r:kernel_t:s0 comm=kworker/u4:1 Signed-off-by: Richard Guy Briggs <[email protected]> Signed-off-by: Paul Moore <[email protected]>
1 parent 0090c1e commit 9d44a12

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

kernel/auditsc.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2557,12 +2557,18 @@ void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries,
25572557
enum audit_nfcfgop op)
25582558
{
25592559
struct audit_buffer *ab;
2560+
char comm[sizeof(current->comm)];
25602561

25612562
ab = audit_log_start(audit_context(), GFP_KERNEL, AUDIT_NETFILTER_CFG);
25622563
if (!ab)
25632564
return;
25642565
audit_log_format(ab, "table=%s family=%u entries=%u op=%s",
25652566
name, af, nentries, audit_nfcfgs[op].s);
2567+
2568+
audit_log_format(ab, " pid=%u", task_pid_nr(current));
2569+
audit_log_task_context(ab); /* subj= */
2570+
audit_log_format(ab, " comm=");
2571+
audit_log_untrustedstring(ab, get_task_comm(comm, current));
25662572
audit_log_end(ab);
25672573
}
25682574
EXPORT_SYMBOL_GPL(__audit_log_nfcfg);

0 commit comments

Comments
 (0)