Skip to content

Commit 9d6a530

Browse files
robherringbebarino
authored andcommitted
clk: at91: Use of_property_count_u32_elems() to get property length
Replace of_get_property() with the type specific of_property_count_u32_elems() to get the property length. This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed. Signed-off-by: Rob Herring (Arm) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]>
1 parent f9848cf commit 9d6a530

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/clk/at91/dt-compat.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -563,9 +563,10 @@ of_at91_clk_pll_get_characteristics(struct device_node *np)
563563
if (num_cells < 2 || num_cells > 4)
564564
return NULL;
565565

566-
if (!of_get_property(np, "atmel,pll-clk-output-ranges", &tmp))
566+
num_output = of_property_count_u32_elems(np, "atmel,pll-clk-output-ranges");
567+
if (num_output <= 0)
567568
return NULL;
568-
num_output = tmp / (sizeof(u32) * num_cells);
569+
num_output /= num_cells;
569570

570571
characteristics = kzalloc(sizeof(*characteristics), GFP_KERNEL);
571572
if (!characteristics)

0 commit comments

Comments
 (0)