Skip to content

Commit 9d7b307

Browse files
geertupalmer-dabbelt
authored andcommitted
riscv: dts: microchip: mpfs: Fix reference clock node
"make dtbs_check" reports: arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dt.yaml: soc: refclk: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[600000000]], 'clock-output-names': ['msspllclk'], 'phandle': [[7]]} should not be valid under {'type': 'object'} From schema: dtschema/schemas/simple-bus.yaml Fix this by moving the node out of the "soc" subnode. While at it, rename it to "msspllclk", and drop the now superfluous "clock-output-names" property. Move the actual clock-frequency value to the board DTS, since it is not set until bitstream programming time. Signed-off-by: Geert Uytterhoeven <[email protected]> Acked-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Conor Dooley <[email protected]> Tested-by: Conor Dooley <[email protected]> Signed-off-by: Palmer Dabbelt <[email protected]>
1 parent 53abf98 commit 9d7b307

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@
3535
};
3636
};
3737

38+
&refclk {
39+
clock-frequency = <600000000>;
40+
};
41+
3842
&serial0 {
3943
status = "okay";
4044
};

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,11 @@
139139
};
140140
};
141141

142+
refclk: msspllclk {
143+
compatible = "fixed-clock";
144+
#clock-cells = <0>;
145+
};
146+
142147
soc {
143148
#address-cells = <2>;
144149
#size-cells = <2>;
@@ -189,13 +194,6 @@
189194
#dma-cells = <1>;
190195
};
191196

192-
refclk: refclk {
193-
compatible = "fixed-clock";
194-
#clock-cells = <0>;
195-
clock-frequency = <600000000>;
196-
clock-output-names = "msspllclk";
197-
};
198-
199197
clkcfg: clkcfg@20002000 {
200198
compatible = "microchip,mpfs-clkcfg";
201199
reg = <0x0 0x20002000 0x0 0x1000>;

0 commit comments

Comments
 (0)