Skip to content

Commit 9d8528a

Browse files
quic-cangmartinkpetersen
authored andcommitted
scsi: ufs: ufs-qcom: Limit HS-G5 Rate-A to hosts with HW version 5
Qcom UFS hosts, with HW ver 5, can only support up to HS-G5 Rate-A due to HW limitations. If the HS-G5 PHY gear is used, update host_params->hs_rate to Rate-A, so that the subsequent power mode changes shall stick to Rate-A. Reviewed-by: Nitin Rawat <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Signed-off-by: Can Guo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Tested-by: Neil Armstrong <[email protected]> # on SM8550-QRD Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 743e1f5 commit 9d8528a

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

drivers/ufs/host/ufs-qcom.c

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,9 +442,25 @@ static u32 ufs_qcom_get_hs_gear(struct ufs_hba *hba)
442442
static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
443443
{
444444
struct ufs_qcom_host *host = ufshcd_get_variant(hba);
445+
struct ufs_host_params *host_params = &host->host_params;
445446
struct phy *phy = host->generic_phy;
447+
enum phy_mode mode;
446448
int ret;
447449

450+
/*
451+
* HW ver 5 can only support up to HS-G5 Rate-A due to HW limitations.
452+
* If the HS-G5 PHY gear is used, update host_params->hs_rate to Rate-A,
453+
* so that the subsequent power mode change shall stick to Rate-A.
454+
*/
455+
if (host->hw_ver.major == 0x5) {
456+
if (host->phy_gear == UFS_HS_G5)
457+
host_params->hs_rate = PA_HS_MODE_A;
458+
else
459+
host_params->hs_rate = PA_HS_MODE_B;
460+
}
461+
462+
mode = host_params->hs_rate == PA_HS_MODE_B ? PHY_MODE_UFS_HS_B : PHY_MODE_UFS_HS_A;
463+
448464
/* Reset UFS Host Controller and PHY */
449465
ret = ufs_qcom_host_reset(hba);
450466
if (ret)
@@ -459,7 +475,7 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
459475
return ret;
460476
}
461477

462-
phy_set_mode_ext(phy, PHY_MODE_UFS_HS_B, host->phy_gear);
478+
phy_set_mode_ext(phy, mode, host->phy_gear);
463479

464480
/* power on phy - start serdes and phy's power and clocks */
465481
ret = phy_power_on(phy);

0 commit comments

Comments
 (0)