Skip to content

Commit 9d8b537

Browse files
rddunlaphdeller
authored andcommitted
fbdev: make offb driver tristate
Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module. However, it still depends on the setting of DRM_OFDRM so that both of these drivers cannot be builtin at the same time nor can one be builtin and the other one a loadable module. Build-tested successfully with all combination of DRM_OFDRM and FB_OF. This fixes a build issue that Michal reported when FB_OF=y and DRM_OFDRM=m: powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect' powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea' powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit' Signed-off-by: Randy Dunlap <[email protected]> Suggested-by: Arnd Bergmann <[email protected]> Cc: Masahiro Yamada <[email protected]> Cc: Thomas Zimmermann <[email protected]> Cc: Michal Suchánek <[email protected]> Cc: [email protected] Cc: Daniel Vetter <[email protected]> Cc: Helge Deller <[email protected]> Cc: [email protected] Cc: [email protected] Acked-by: Thomas Zimmermann <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent 1b929c0 commit 9d8b537

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/video/fbdev/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,8 +456,8 @@ config FB_ATARI
456456
chipset found in Ataris.
457457

458458
config FB_OF
459-
bool "Open Firmware frame buffer device support"
460-
depends on (FB = y) && PPC && (!PPC_PSERIES || PCI)
459+
tristate "Open Firmware frame buffer device support"
460+
depends on FB && PPC && (!PPC_PSERIES || PCI)
461461
depends on !DRM_OFDRM
462462
select APERTURE_HELPERS
463463
select FB_CFB_FILLRECT

0 commit comments

Comments
 (0)