Skip to content

Commit 9dc0033

Browse files
ptf2storulf
authored andcommitted
mmc: sdhci-pci-core: Disable ES for ASUS BIOS on Jasper Lake
Enhanced Strobe (ES) does not work correctly on the ASUS 1100 series of devices. Jasper Lake eMMCs (pci_id 8086:4dc4) are supposed to support ES. There are also two system families under the series, thus this is being scoped to the ASUS BIOS. The failing ES prevents the installer from writing to disk. Falling back to HS400 without ES fixes the issue. Signed-off-by: Patrick Thompson <[email protected]> Fixes: 315e3bd ("mmc: sdhci-pci: Add support for Intel JSL") Acked-by: Adrian Hunter <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ulf Hansson <[email protected]>
1 parent 1ed5c3b commit 9dc0033

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

drivers/mmc/host/sdhci-pci-core.c

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -914,6 +914,12 @@ static bool glk_broken_cqhci(struct sdhci_pci_slot *slot)
914914
dmi_match(DMI_SYS_VENDOR, "IRBIS"));
915915
}
916916

917+
static bool jsl_broken_hs400es(struct sdhci_pci_slot *slot)
918+
{
919+
return slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_JSL_EMMC &&
920+
dmi_match(DMI_BIOS_VENDOR, "ASUSTeK COMPUTER INC.");
921+
}
922+
917923
static int glk_emmc_probe_slot(struct sdhci_pci_slot *slot)
918924
{
919925
int ret = byt_emmc_probe_slot(slot);
@@ -922,9 +928,11 @@ static int glk_emmc_probe_slot(struct sdhci_pci_slot *slot)
922928
slot->host->mmc->caps2 |= MMC_CAP2_CQE;
923929

924930
if (slot->chip->pdev->device != PCI_DEVICE_ID_INTEL_GLK_EMMC) {
925-
slot->host->mmc->caps2 |= MMC_CAP2_HS400_ES;
926-
slot->host->mmc_host_ops.hs400_enhanced_strobe =
927-
intel_hs400_enhanced_strobe;
931+
if (!jsl_broken_hs400es(slot)) {
932+
slot->host->mmc->caps2 |= MMC_CAP2_HS400_ES;
933+
slot->host->mmc_host_ops.hs400_enhanced_strobe =
934+
intel_hs400_enhanced_strobe;
935+
}
928936
slot->host->mmc->caps2 |= MMC_CAP2_CQE_DCMD;
929937
}
930938

0 commit comments

Comments
 (0)