Skip to content

Commit 9e320d7

Browse files
ConchuODpalmer-dabbelt
authored andcommitted
dt-bindings: riscv: drop invalid comment about riscv,isa lower-case reasoning
"Ease of parsing" may have been the initial argument for keeping this string in lower-case, but parsers may have been written that expect lower-case only. For example, the one in released kernels currently does not behave correctly for multi-letter extensions that begin with a capital letter. Allowing upper-case here brings about no benefit but would break compatibility between new devicetrees and older kernels. Drop the comment to avoid confusing people. Signed-off-by: Conor Dooley <[email protected]> Reviewed-by: Andrew Jones <[email protected]> Acked-by: Rob Herring <[email protected]> Signed-off-by: Yangyu Chen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Palmer Dabbelt <[email protected]>
1 parent 255b34d commit 9e320d7

File tree

1 file changed

+1
-1
lines changed
  • Documentation/devicetree/bindings/riscv

1 file changed

+1
-1
lines changed

Documentation/devicetree/bindings/riscv/cpus.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ properties:
9494

9595
While the isa strings in ISA specification are case
9696
insensitive, letters in the riscv,isa string must be all
97-
lowercase to simplify parsing.
97+
lowercase.
9898
$ref: "/schemas/types.yaml#/definitions/string"
9999
pattern: ^rv(?:64|32)imaf?d?q?c?b?k?j?p?v?h?(?:[hsxz](?:[a-z])+)?(?:_[hsxz](?:[a-z])+)*$
100100

0 commit comments

Comments
 (0)