Skip to content

Commit 9e5b59e

Browse files
jhovoldvinodkoul
authored andcommitted
phy: qcom-qmp-combo: rename common-register pointers
The common registers are shared by the USB and DP parts of the PHY so drop the misleading "dp" prefix from the corresponding pointers. Note that the "DP" prefix could also be dropped from the corresponding defines, but leave that in place for now. Reviewed-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent b71bf1e commit 9e5b59e

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

drivers/phy/qualcomm/phy-qcom-qmp-combo.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -864,7 +864,7 @@ struct qmp_combo {
864864

865865
const struct qmp_phy_cfg *cfg;
866866

867-
void __iomem *dp_com;
867+
void __iomem *com;
868868

869869
void __iomem *serdes;
870870
void __iomem *tx;
@@ -1767,7 +1767,7 @@ static int qmp_combo_dp_calibrate(struct phy *phy)
17671767
static int qmp_combo_com_init(struct qmp_combo *qmp)
17681768
{
17691769
const struct qmp_phy_cfg *cfg = qmp->cfg;
1770-
void __iomem *dp_com = qmp->dp_com;
1770+
void __iomem *com = qmp->com;
17711771
int ret;
17721772

17731773
mutex_lock(&qmp->phy_mutex);
@@ -1798,25 +1798,25 @@ static int qmp_combo_com_init(struct qmp_combo *qmp)
17981798
if (ret)
17991799
goto err_assert_reset;
18001800

1801-
qphy_setbits(dp_com, QPHY_V3_DP_COM_POWER_DOWN_CTRL, SW_PWRDN);
1801+
qphy_setbits(com, QPHY_V3_DP_COM_POWER_DOWN_CTRL, SW_PWRDN);
18021802

18031803
/* override hardware control for reset of qmp phy */
1804-
qphy_setbits(dp_com, QPHY_V3_DP_COM_RESET_OVRD_CTRL,
1804+
qphy_setbits(com, QPHY_V3_DP_COM_RESET_OVRD_CTRL,
18051805
SW_DPPHY_RESET_MUX | SW_DPPHY_RESET |
18061806
SW_USB3PHY_RESET_MUX | SW_USB3PHY_RESET);
18071807

18081808
/* Default type-c orientation, i.e CC1 */
1809-
qphy_setbits(dp_com, QPHY_V3_DP_COM_TYPEC_CTRL, 0x02);
1809+
qphy_setbits(com, QPHY_V3_DP_COM_TYPEC_CTRL, 0x02);
18101810

1811-
qphy_setbits(dp_com, QPHY_V3_DP_COM_PHY_MODE_CTRL, USB3_MODE | DP_MODE);
1811+
qphy_setbits(com, QPHY_V3_DP_COM_PHY_MODE_CTRL, USB3_MODE | DP_MODE);
18121812

18131813
/* bring both QMP USB and QMP DP PHYs PCS block out of reset */
1814-
qphy_clrbits(dp_com, QPHY_V3_DP_COM_RESET_OVRD_CTRL,
1814+
qphy_clrbits(com, QPHY_V3_DP_COM_RESET_OVRD_CTRL,
18151815
SW_DPPHY_RESET_MUX | SW_DPPHY_RESET |
18161816
SW_USB3PHY_RESET_MUX | SW_USB3PHY_RESET);
18171817

1818-
qphy_clrbits(dp_com, QPHY_V3_DP_COM_SWI_CTRL, 0x03);
1819-
qphy_clrbits(dp_com, QPHY_V3_DP_COM_SW_RESET, SW_RESET);
1818+
qphy_clrbits(com, QPHY_V3_DP_COM_SWI_CTRL, 0x03);
1819+
qphy_clrbits(com, QPHY_V3_DP_COM_SW_RESET, SW_RESET);
18201820

18211821
qphy_setbits(qmp->pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL],
18221822
SW_PWRDN);
@@ -2538,9 +2538,9 @@ static int qmp_combo_parse_dt_legacy(struct qmp_combo *qmp, struct device_node *
25382538
if (IS_ERR(qmp->serdes))
25392539
return PTR_ERR(qmp->serdes);
25402540

2541-
qmp->dp_com = devm_platform_ioremap_resource(pdev, 1);
2542-
if (IS_ERR(qmp->dp_com))
2543-
return PTR_ERR(qmp->dp_com);
2541+
qmp->com = devm_platform_ioremap_resource(pdev, 1);
2542+
if (IS_ERR(qmp->com))
2543+
return PTR_ERR(qmp->com);
25442544

25452545
qmp->dp_serdes = devm_platform_ioremap_resource(pdev, 2);
25462546
if (IS_ERR(qmp->dp_serdes))

0 commit comments

Comments
 (0)