Skip to content

Commit 9e661ce

Browse files
author
Wolfram Sang
committed
i2c: jz4780: silence log flood on txabrt
The printout for txabrt is way too talkative and is highly annoying with scanning programs like 'i2cdetect'. Reduce it to the minimum, the rest can be gained by I2C core debugging and datasheet information. Also, make it a debug printout, it won't help the regular user. Fixes: ba92222 ("i2c: jz4780: Add i2c bus controller driver for Ingenic JZ4780") Reported-by: H. Nikolaus Schaller <[email protected]> Tested-by: H. Nikolaus Schaller <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent bb6d3fb commit 9e661ce

File tree

1 file changed

+2
-34
lines changed

1 file changed

+2
-34
lines changed

drivers/i2c/busses/i2c-jz4780.c

Lines changed: 2 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -78,25 +78,6 @@
7878

7979
#define X1000_I2C_DC_STOP BIT(9)
8080

81-
static const char * const jz4780_i2c_abrt_src[] = {
82-
"ABRT_7B_ADDR_NOACK",
83-
"ABRT_10ADDR1_NOACK",
84-
"ABRT_10ADDR2_NOACK",
85-
"ABRT_XDATA_NOACK",
86-
"ABRT_GCALL_NOACK",
87-
"ABRT_GCALL_READ",
88-
"ABRT_HS_ACKD",
89-
"SBYTE_ACKDET",
90-
"ABRT_HS_NORSTRT",
91-
"SBYTE_NORSTRT",
92-
"ABRT_10B_RD_NORSTRT",
93-
"ABRT_MASTER_DIS",
94-
"ARB_LOST",
95-
"SLVFLUSH_TXFIFO",
96-
"SLV_ARBLOST",
97-
"SLVRD_INTX",
98-
};
99-
10081
#define JZ4780_I2C_INTST_IGC BIT(11)
10182
#define JZ4780_I2C_INTST_ISTT BIT(10)
10283
#define JZ4780_I2C_INTST_ISTP BIT(9)
@@ -576,21 +557,8 @@ static irqreturn_t jz4780_i2c_irq(int irqno, void *dev_id)
576557

577558
static void jz4780_i2c_txabrt(struct jz4780_i2c *i2c, int src)
578559
{
579-
int i;
580-
581-
dev_err(&i2c->adap.dev, "txabrt: 0x%08x\n", src);
582-
dev_err(&i2c->adap.dev, "device addr=%x\n",
583-
jz4780_i2c_readw(i2c, JZ4780_I2C_TAR));
584-
dev_err(&i2c->adap.dev, "send cmd count:%d %d\n",
585-
i2c->cmd, i2c->cmd_buf[i2c->cmd]);
586-
dev_err(&i2c->adap.dev, "receive data count:%d %d\n",
587-
i2c->cmd, i2c->data_buf[i2c->cmd]);
588-
589-
for (i = 0; i < 16; i++) {
590-
if (src & BIT(i))
591-
dev_dbg(&i2c->adap.dev, "I2C TXABRT[%d]=%s\n",
592-
i, jz4780_i2c_abrt_src[i]);
593-
}
560+
dev_dbg(&i2c->adap.dev, "txabrt: 0x%08x, cmd: %d, send: %d, recv: %d\n",
561+
src, i2c->cmd, i2c->cmd_buf[i2c->cmd], i2c->data_buf[i2c->cmd]);
594562
}
595563

596564
static inline int jz4780_i2c_xfer_read(struct jz4780_i2c *i2c,

0 commit comments

Comments
 (0)