Skip to content

Commit 9e69b1b

Browse files
mszyprowTzung-Bi Shih
authored andcommitted
platform/chrome: cros_ec: Fix panic notifier registration
Initialize panic notifier to avoid the following lockdep warning: INFO: trying to register non-static key. The code is fine but needs lockdep annotation, or maybe you didn't initialize this object before use? turning off the locking correctness validator. [...] Hardware name: Samsung Exynos (Flattened Device Tree) Workqueue: events_unbound async_run_entry_fn unwind_backtrace from show_stack [...] blocking_notifier_chain_register from cros_ec_debugfs_probe cros_ec_debugfs_probe from platform_probe Fixes: d90fa2c ("platform/chrome: cros_ec: Poll EC log on EC panic") Signed-off-by: Marek Szyprowski <[email protected]> [tzungbi: trimmed the stack trace in commit message.] Signed-off-by: Tzung-Bi Shih <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 441529b commit 9e69b1b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/platform/chrome/cros_ec.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
182182
int err = 0;
183183

184184
BLOCKING_INIT_NOTIFIER_HEAD(&ec_dev->event_notifier);
185+
BLOCKING_INIT_NOTIFIER_HEAD(&ec_dev->panic_notifier);
185186

186187
ec_dev->max_request = sizeof(struct ec_params_hello);
187188
ec_dev->max_response = sizeof(struct ec_response_get_protocol_info);

0 commit comments

Comments
 (0)