Skip to content

Commit 9e69e84

Browse files
jlabundydtor
authored andcommitted
dt-bindings: input: iqs626a: Redefine trackpad property types
Following a recent refactor of the driver to properly drop unused device nodes, the driver expects trackpad channel touch thresholds and ATI base values to be specified under single trackpad channel child nodes. This enhancement moves both properties to scalar values as opposed to arrays, making their types consistent across bindings. Fixes: a8f1f0d ("dt-bindings: input: Add bindings for Azoteq IQS626A") Signed-off-by: Jeff LaBundy <[email protected]> Reviewed-by: Rob Herring <[email protected]> Link: https://lore.kernel.org/r/Y9RQcddToBr1rrnJ@nixie71 Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent 4d3d269 commit 9e69e84

File tree

1 file changed

+67
-27
lines changed

1 file changed

+67
-27
lines changed

Documentation/devicetree/bindings/input/iqs626a.yaml

Lines changed: 67 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -564,16 +564,6 @@ patternProperties:
564564
2: Partial
565565
3: Full
566566
567-
azoteq,ati-base:
568-
$ref: /schemas/types.yaml#/definitions/uint32-array
569-
minItems: 6
570-
maxItems: 9
571-
items:
572-
minimum: 45
573-
maximum: 300
574-
default: [45, 45, 45, 45, 45, 45, 45, 45, 45]
575-
description: Specifies each individual trackpad channel's ATI base.
576-
577567
azoteq,ati-target:
578568
$ref: /schemas/types.yaml#/definitions/uint32
579569
multipleOf: 32
@@ -620,17 +610,6 @@ patternProperties:
620610
description:
621611
Tightens the ATI band from 1/8 to 1/16 of the desired target.
622612

623-
azoteq,thresh:
624-
$ref: /schemas/types.yaml#/definitions/uint32-array
625-
minItems: 6
626-
maxItems: 9
627-
items:
628-
minimum: 0
629-
maximum: 255
630-
default: [0, 0, 0, 0, 0, 0, 0, 0, 0]
631-
description:
632-
Specifies each individual trackpad channel's touch threshold.
633-
634613
azoteq,hyst:
635614
$ref: /schemas/types.yaml#/definitions/uint32
636615
minimum: 0
@@ -720,6 +699,28 @@ patternProperties:
720699
Specifies the number of points across which an axial gesture must
721700
travel in order to be interpreted as a flick or swipe.
722701

702+
patternProperties:
703+
"^channel-[0-8]$":
704+
type: object
705+
description: Represents a single trackpad channel.
706+
707+
properties:
708+
azoteq,thresh:
709+
$ref: /schemas/types.yaml#/definitions/uint32
710+
minimum: 0
711+
maximum: 255
712+
default: 0
713+
description: Specifies the threshold for the channel.
714+
715+
azoteq,ati-base:
716+
$ref: /schemas/types.yaml#/definitions/uint32
717+
minimum: 45
718+
maximum: 300
719+
default: 45
720+
description: Specifies the channel's ATI base.
721+
722+
additionalProperties: false
723+
723724
dependencies:
724725
azoteq,gesture-swipe: ["linux,keycodes"]
725726
azoteq,timeout-tap-ms: ["linux,keycodes"]
@@ -780,14 +781,8 @@ examples:
780781
azoteq,filt-str-lp-cnt = <1>;
781782
782783
azoteq,hyst = <4>;
783-
azoteq,thresh = <35>, <40>, <40>,
784-
<38>, <33>, <38>,
785-
<35>, <35>, <35>;
786784
787785
azoteq,ati-mode = <3>;
788-
azoteq,ati-base = <195>, <195>, <195>,
789-
<195>, <195>, <195>,
790-
<195>, <195>, <195>;
791786
azoteq,ati-target = <512>;
792787
793788
azoteq,proj-bias = <1>;
@@ -804,6 +799,51 @@ examples:
804799
azoteq,timeout-swipe-ms = <800>;
805800
azoteq,timeout-tap-ms = <400>;
806801
azoteq,thresh-swipe = <40>;
802+
803+
channel-0 {
804+
azoteq,thresh = <35>;
805+
azoteq,ati-base = <195>;
806+
};
807+
808+
channel-1 {
809+
azoteq,thresh = <40>;
810+
azoteq,ati-base = <195>;
811+
};
812+
813+
channel-2 {
814+
azoteq,thresh = <40>;
815+
azoteq,ati-base = <195>;
816+
};
817+
818+
channel-3 {
819+
azoteq,thresh = <38>;
820+
azoteq,ati-base = <195>;
821+
};
822+
823+
channel-4 {
824+
azoteq,thresh = <33>;
825+
azoteq,ati-base = <195>;
826+
};
827+
828+
channel-5 {
829+
azoteq,thresh = <38>;
830+
azoteq,ati-base = <195>;
831+
};
832+
833+
channel-6 {
834+
azoteq,thresh = <35>;
835+
azoteq,ati-base = <195>;
836+
};
837+
838+
channel-7 {
839+
azoteq,thresh = <35>;
840+
azoteq,ati-base = <195>;
841+
};
842+
843+
channel-8 {
844+
azoteq,thresh = <35>;
845+
azoteq,ati-base = <195>;
846+
};
807847
};
808848
809849
/*

0 commit comments

Comments
 (0)