Skip to content

Commit 9e72a55

Browse files
dickmanmaorSaeed Mahameed
authored andcommitted
net/mlx5e: Don't block routes with nexthop objects in SW
Routes with nexthop objects is currently not supported by multipath offload and any attempts to use it is blocked, however this also block adding SW routes with nexthop. Resolve this by returning NOTIFY_DONE instead of an error which will allow such a route to be created in SW but not offloaded. This fix also solve an issue which block adding such routes on different devices due to missing check if the route FIB device is one of multipath devices. Fixes: 6a87afc ("mlx5: Fail attempts to use routes with nexthop objects") Signed-off-by: Maor Dickman <[email protected]> Reviewed-by: Roi Dayan <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 885751e commit 9e72a55

File tree

1 file changed

+2
-4
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core/lag

1 file changed

+2
-4
lines changed

drivers/net/ethernet/mellanox/mlx5/core/lag/mp.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,8 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
268268
fen_info = container_of(info, struct fib_entry_notifier_info,
269269
info);
270270
fi = fen_info->fi;
271-
if (fi->nh) {
272-
NL_SET_ERR_MSG_MOD(info->extack, "IPv4 route with nexthop objects is not supported");
273-
return notifier_from_errno(-EINVAL);
274-
}
271+
if (fi->nh)
272+
return NOTIFY_DONE;
275273
fib_dev = fib_info_nh(fen_info->fi, 0)->fib_nh_dev;
276274
if (fib_dev != ldev->pf[MLX5_LAG_P1].netdev &&
277275
fib_dev != ldev->pf[MLX5_LAG_P2].netdev) {

0 commit comments

Comments
 (0)