Skip to content

Commit 9e8534f

Browse files
committed
dns_resolver: avoid pointless cred reference count bump
The dns_resolver_cache creds hold a long-term reference that is stable during the operation. Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Jeff Layton <[email protected]> Reviewed-by: Jens Axboe <[email protected]> Signed-off-by: Christian Brauner <[email protected]>
1 parent aeca632 commit 9e8534f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

net/dns_resolver/dns_query.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ int dns_query(struct net *net,
124124
/* make the upcall, using special credentials to prevent the use of
125125
* add_key() to preinstall malicious redirections
126126
*/
127-
saved_cred = override_creds(get_new_cred(dns_resolver_cache));
127+
saved_cred = override_creds(dns_resolver_cache);
128128
rkey = request_key_net(&key_type_dns_resolver, desc, net, options);
129-
put_cred(revert_creds(saved_cred));
129+
revert_creds(saved_cred);
130130
kfree(desc);
131131
if (IS_ERR(rkey)) {
132132
ret = PTR_ERR(rkey);

0 commit comments

Comments
 (0)