staging: gpib: Fix inadvertent negative shift

dpenkler · gregkh · commit 9ed145e64f0a · 2025-01-16T13:23:35.000+01:00
During the initial checkpatch cleanup, when removing blanks after open parentheses, a minus sign in the argument of a shift operation was deleted by mistake. This transformed a pre-decrement operation into a negation. The result of a negative shift is undefined and a warning was signalled by sparse. Restore the pre-decrement operation. Fixes: 6c52d5e ("staging: gpib: Add common include files for GPIB drivers") Signed-off-by: Dave Penkler <dpenkler@gmail.com> Link: https://lore.kernel.org/r/20250116110014.15577-1-dpenkler@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/staging/gpib/include/amcc5920.h b/drivers/staging/gpib/include/amcc5920.h
@@ -22,7 +22,7 @@ static const int bits_per_region = 8;
 
 static inline uint32_t amcc_wait_state_bits(unsigned int region, unsigned int num_wait_states)
 {
-	return (num_wait_states & 0x7) << (-region * bits_per_region);
+	return (num_wait_states & 0x7) << (--region * bits_per_region);
 };
 
 enum amcc_prefetch_bits {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ static const int bits_per_region = 8;`
`22`	`22`
`23`	`23`	`static inline uint32_t amcc_wait_state_bits(unsigned int region, unsigned int num_wait_states)`
`24`	`24`	`{`
`25`		`- return (num_wait_states & 0x7) << (-region * bits_per_region);`
	`25`	`+ return (num_wait_states & 0x7) << (--region * bits_per_region);`
`26`	`26`	`};`
`27`	`27`
`28`	`28`	`enum amcc_prefetch_bits {`