Skip to content

Commit 9f2072c

Browse files
Uwe Kleine-Königandreas-gaisler
authored andcommitted
sparc: parport: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <[email protected]> Reviewed-by: Andreas Larsson <[email protected]> Link: https://lore.kernel.org/r/2765e090dba2d99f92e16c92b6aa55090aae053b.1712755381.git.u.kleine-koenig@pengutronix.de Signed-off-by: Andreas Larsson <[email protected]>
1 parent c7933ea commit 9f2072c

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

arch/sparc/include/asm/parport_64.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ static int ecpp_probe(struct platform_device *op)
196196
return err;
197197
}
198198

199-
static int ecpp_remove(struct platform_device *op)
199+
static void ecpp_remove(struct platform_device *op)
200200
{
201201
struct parport *p = dev_get_drvdata(&op->dev);
202202
int slot = p->dma;
@@ -216,8 +216,6 @@ static int ecpp_remove(struct platform_device *op)
216216
d_len);
217217
clear_bit(slot, dma_slot_map);
218218
}
219-
220-
return 0;
221219
}
222220

223221
static const struct of_device_id ecpp_match[] = {
@@ -245,7 +243,7 @@ static struct platform_driver ecpp_driver = {
245243
.of_match_table = ecpp_match,
246244
},
247245
.probe = ecpp_probe,
248-
.remove = ecpp_remove,
246+
.remove_new = ecpp_remove,
249247
};
250248

251249
static int parport_pc_find_nonpci_ports(int autoirq, int autodma)

0 commit comments

Comments
 (0)