Skip to content

Commit 9f4db31

Browse files
diandersbebarino
authored andcommitted
dt-bindings: clock: Fix YAML schemas for LPASS clocks on SC7180
The YAML schemas that landed forgot one clock: "bi_tcxo". Presumably the bindings were developed against the v4 version of the driver and when the ".name" was removed in v5 of the driver things broke. While touching this, add the needed includes in each example. I believe both examples are supposed to be independent of each other. Let's fix the bindings. Fixes: 381cc6f ("dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180") Signed-off-by: Douglas Anderson <[email protected]> Link: https://lore.kernel.org/r/20200731133006.1.Iee81b115f5be50d6d69500fe1bda11bba6e16143@changeid Signed-off-by: Stephen Boyd <[email protected]>
1 parent 3386af5 commit 9f4db31

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

Documentation/devicetree/bindings/clock/qcom,sc7180-lpasscorecc.yaml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,12 @@ properties:
2525
clocks:
2626
items:
2727
- description: gcc_lpass_sway clock from GCC
28+
- description: Board XO source
2829

2930
clock-names:
3031
items:
3132
- const: iface
33+
- const: bi_tcxo
3234

3335
power-domains:
3436
maxItems: 1
@@ -77,24 +79,28 @@ additionalProperties: false
7779

7880
examples:
7981
- |
82+
#include <dt-bindings/clock/qcom,rpmh.h>
8083
#include <dt-bindings/clock/qcom,gcc-sc7180.h>
8184
#include <dt-bindings/clock/qcom,lpasscorecc-sc7180.h>
8285
clock-controller@63000000 {
8386
compatible = "qcom,sc7180-lpasshm";
8487
reg = <0x63000000 0x28>;
85-
clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>;
86-
clock-names = "iface";
88+
clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, <&rpmhcc RPMH_CXO_CLK>;
89+
clock-names = "iface", "bi_tcxo";
8790
#clock-cells = <1>;
8891
#power-domain-cells = <1>;
8992
};
9093
9194
- |
95+
#include <dt-bindings/clock/qcom,rpmh.h>
96+
#include <dt-bindings/clock/qcom,gcc-sc7180.h>
97+
#include <dt-bindings/clock/qcom,lpasscorecc-sc7180.h>
9298
clock-controller@62d00000 {
9399
compatible = "qcom,sc7180-lpasscorecc";
94100
reg = <0x62d00000 0x50000>, <0x62780000 0x30000>;
95101
reg-names = "lpass_core_cc", "lpass_audio_cc";
96-
clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>;
97-
clock-names = "iface";
102+
clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>, <&rpmhcc RPMH_CXO_CLK>;
103+
clock-names = "iface", "bi_tcxo";
98104
power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
99105
#clock-cells = <1>;
100106
#power-domain-cells = <1>;

0 commit comments

Comments
 (0)