Skip to content

Commit 9f6acd2

Browse files
CFSworksmmind
authored andcommitted
arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls
The pinctrls for the hym8563 interrupt line and fan-tach input were both mistakenly defined as `pcfg_pull_none`. As these are active-low signals (level-triggered, in the hym8563 case) which may not be driven at times, these should really be pull-up. The lack of any bias results in spurious interrupts. Fix this by modifying the `rockchip,pins` properties as necessary to enable the pull-up resistors. Fixes: 2806a69 ("arm64: dts: rockchip: Add Turing RK1 SoM support") Signed-off-by: Sam Edwards <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 0c349b5 commit 9f6acd2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,13 +235,13 @@
235235
&pinctrl {
236236
fan {
237237
fan_int: fan-int {
238-
rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>;
238+
rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>;
239239
};
240240
};
241241

242242
hym8563 {
243243
hym8563_int: hym8563-int {
244-
rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
244+
rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
245245
};
246246
};
247247

0 commit comments

Comments
 (0)